search

microsoft / TypeScript-Node-Starter

A reference example for TypeScript and Node with a detailed README describing how to use the two together.
MIT License
11.3k stars 2.76k forks source link

🚀 github-actions azure deploy #302

Open bmiddha opened 3 years ago

bmiddha commented 3 years ago

Added GitHub Actions workflow to deploy to Azure Web App. Will require AZURE_WEBAPP_PUBLISH_PROFILE secret to be configured in GitHub. image

The Azure Web App is also expected to have the environment variables configured (https://docs.microsoft.com/en-us/azure/app-service/configure-common#configure-app-settings)

peterblazejewicz commented 3 years ago

/cc @diberry

diberry commented 3 years ago

@peterblazejewicz How is this PR tested so that it works and then the demo can start working again?

peterblazejewicz commented 3 years ago

@diberry you're correct, thx!

@bmiddha so it works on a machine with hosted agent that can access Docker runtime directly. I don't have access to the project website on azure, but I guess it was never setup using the CI to build and deploy (due to MongoDB image dependency). So technically there is no runtime to properly execute all steps in the pipeline (at least for this very project website). Are you changes intended as an example how to use CI (on Azure DevOps) to build a project like that one and deploy it to working environment?

@diberry do you know someone from MS that owns this project? If not I'll ask Orta

diberry commented 3 years ago

@peterblazejewicz - I don't know who owns it - sorry - if you find out, please let me know.

orta commented 2 years ago

Looks like its not in any of the TypeScript Azure properties, so I don't have access keys to be able to add to the GH actions secret. I think we should probably drop the link.