Fix #305 Update packages to latest

microsoft / TypeScript-Node-Starter

A reference example for TypeScript and Node with a detailed README describing how to use the two together.

MIT License

11.29k stars 2.76k forks source link

Fix #305 Update packages to latest #317

Closed samal-rasmussen closed 3 years ago

samal-rasmussen commented 3 years ago

Fix #305

Had to add/modify a lot of types.
I had to use a specific github commit for the connect-mongo dependency because of this: https://github.com/jdesboeufs/connect-mongo/issues/373
Added express-session-types.d.ts in order to get returnTo on SessionData

peterblazejewicz commented 3 years ago

@samal-rasmussen can you force push changes? I cannot see came CI error locally (build/linter/tests)

samal-rasmussen commented 3 years ago

The original travis ci build errors were caused by node-sass, which is deprecated so I went ahead and changed over to the sass package and that seems to have worked for that issue.

But now the build is failing on optional catch bindings in the new versions of the dependencies. This was introduces in node 10 and the travis build is using 8 and 9. So this pr is stranded until someone updates the ci build.

peterblazejewicz commented 3 years ago

@samal-rasmussen i've changed the versions to be LTSs. Still, you need to take latest (rebase) and push changes with updated .yml, thx!

samal-rasmussen commented 3 years ago

Oh that's how Travis works. Had I known it was that easy :)