search

microsoft / TypeScript-React-Native-Starter

A starter template for TypeScript and React Native with a detailed README describing how to use the two together.
MIT License
1.91k stars 211 forks source link

Update README.md for recent react-native versions #24

Open TheaLanherne opened 6 years ago

TheaLanherne commented 6 years ago

Since react-native 49, react-native init has been simplified so that it now just creates a single index.js file instead of an index.android.js and an index.ios.js

I've updated the readme instructions to reflect this change, mostly it has just simplified the setup process 👍 I don't know if this PR is something you'll want to merge or not, as it means that your readme instructions will no longer be quite correct for people who used react-native init with a version < 49.

Thanks for the detailed walk-through anyway, I found it really useful! 😄

msftclas commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: TheaLanherne sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

mosesoak commented 6 years ago

@TheaWork using your work from this PR, thanks - I noticed one spot you missed, under the heading Moving files over to TypeScript