search

microsoft / TypeScript-React-Starter

A starter template for TypeScript and React with a detailed README describing how to use the two together.
MIT License
11.09k stars 1.21k forks source link

Fix README props issues #219

Open leticiawanderley opened 6 years ago

leticiawanderley commented 6 years ago

This PR fixes bugs #171 and #212. It makes the attribute name inside the component Hello optional to prevent this error.

missing-name

And renames the interface Props to IProps to adapt to the linting rules.

props
gasparsigma commented 5 years ago

Good fix for #171, well done ! #212 was mistakenly reported as a bug, it's by design that name property is mandatory. Further explanation on the bug report itself. It'd be better to create separate PRs for each bug