search

microsoft / TypeScript-Sublime-Plugin

IO wrapper around TypeScript language services, allowing for easy consumption by editor plugins
Apache License 2.0
1.72k stars 235 forks source link

Find results selection highlight bug in Sublime Text 3 #622

Open webmatrixxxl opened 7 years ago

webmatrixxxl commented 7 years ago

Hello.

I found that when I search for something in document the highlighting of the word disappears after short time and we can see witch was the matched text.

I tried clean instal of the latest version of Sublime Text 3 (3143) with no extensions or plugins/packages nor themes. Right after I install TypeScript package the above behaviour appears.

OS: macOS High Sierra

Here is a demo: https://cl.ly/272B0r2q3u45

bjornstar commented 6 years ago

I'm seeing this as well after having to re-install the typescript-sublime-plugin which broke when I upgraded to OS X to High Sierra.

bjornstar commented 6 years ago

Any ideas as to what might be causing this? I'm getting increasingly frustrated with TypeScript as a result of this bug.

shivanshu3 commented 6 years ago

Dupe of #529?

webmatrixxxl commented 6 years ago

@shivanshu3 Looks like so

bjornstar commented 6 years ago

So what have people been doing to work around this bug? Do you install VSCode? Do you install a different plugin? Do you just deal with it?

I'd love to be able to use this plugin, but highlighting of my search results seems more important than displaying types.

chandrewz commented 5 years ago

@bjornstar an alternative is TypeScript Syntax where the Ctrl/Cmd+F highlight works. I am using this now.

ilyakamens commented 5 years ago

Happening to me too. OS X Mojave 10.14.2 (18C54). Sublime Text 3.1.1 Build 3176.

It's pretty annoying. Any word?

ilyakamens commented 5 years ago

It's because of this: https://github.com/Microsoft/TypeScript-Sublime-Plugin/blob/master/typescript/listeners/idle.py#L212, which ends up being called when this evaluates to True: https://github.com/Microsoft/TypeScript-Sublime-Plugin/blob/master/typescript/listeners/idle.py#L78

Adding "typescript_highlight_occurrences": false, in my ST3 user settings (cmd + comma on mac) seems to work.

Edit: see the comment below.

I noticed that too after a minute. I still prefer it to the original behavior. I'll have to dig deeper. Will post again here if I make any progress.

DomDiPasquale5 commented 5 years ago

Setting typescript_highlight_occurrences to false allows my find results on the currently viewed page to remain highlighted, but if the next find result requires my window to scroll, I still lose my highlighting