search

microsoft / TypeScript-Sublime-Plugin

IO wrapper around TypeScript language services, allowing for easy consumption by editor plugins
Apache License 2.0
1.72k stars 235 forks source link

formatted ReadMe with correct path for Typescript sublime plugin installation (for both mac and windows) #641

Closed mhaviv closed 4 years ago

DanielRosenwasser commented 6 years ago

While the .git is optional, the second command doesn't seem to be correct. Thanks for the PR though!

mhaviv commented 6 years ago

Hi Daniel sorry about that! I realized there is an extra Typescript written in the second command :// I will pr the correct changes. Also I didn’t know that about the .git thank you for the feedback! I’ll add it back also

mhaviv commented 6 years ago

Hi @DanielRosenwasser! let me know if all the changes are correct 😊

DanielRosenwasser commented 6 years ago

There are no changes according to GitHub, so they look correct. 🙃

mhaviv commented 6 years ago

That’s odd... 🤥 if you look at the commit itself there are changes idk why it states there aren’t changes but I can double check again

mhaviv commented 6 years ago

3d3dca97-8d89-4f5e-9545-bd9ba1d41ee2

mhaviv commented 6 years ago

Hi @DanielRosenwasser! I double checked that the changes are there. I also added github pull request and github Issue badges to the readme. Let me know if everything looks good 😊

orta commented 4 years ago

Hi @mhaviv - thanks for the PR, I don't think we want to display these on the README. It doesn't really add too much value for people in comparison to putting something infront of the README's actual content - I'm gonna close this PR

Thanks for trying to help though!