Closed mhaviv closed 4 years ago
Hi Daniel sorry about that! I realized there is an extra Typescript written in the second command :// I will pr the correct changes. Also I didn’t know that about the .git thank you for the feedback! I’ll add it back also
Hi @DanielRosenwasser! let me know if all the changes are correct 😊
There are no changes according to GitHub, so they look correct. 🙃
That’s odd... 🤥 if you look at the commit itself there are changes idk why it states there aren’t changes but I can double check again
Hi @DanielRosenwasser! I double checked that the changes are there. I also added github pull request and github Issue badges to the readme. Let me know if everything looks good 😊
Hi @mhaviv - thanks for the PR, I don't think we want to display these on the README. It doesn't really add too much value for people in comparison to putting something infront of the README's actual content - I'm gonna close this PR
Thanks for trying to help though!
While the
.git
is optional, the second command doesn't seem to be correct. Thanks for the PR though!