Closed it6 closed 5 years ago
Looks sweet! I like how this just applies a quick fix if only one is available. However, I'm getting some strange behavior with carriage returns; notice the CR
character:
Which OS
is this? On mac
I don't see the CR
character. Do you have any setting in sublime
to show line ending characters?
I looked at tsc
response 'newText': ' bar: any;\n'
which is expected with \n
at the end not sure how to debug without reproducing it.
If the file doesn't have Unix line endings can you change it and see if that fixes it
I made a code change to replace CRLF & CR
characters to newline
characters, please see if that fixes it
Is there anything else needed for this?
Is there any way this can make it to the released package? It's working well for me when I manually replace the files in the sublime package directory
Since @DanielRosenwasser review has been take into account, what is blocking this PR to be merged ?
TBH, looks to me like all feedback is addressed and this PR should be merged 👍
fixes #630