search

microsoft / TypeScript-Sublime-Plugin

IO wrapper around TypeScript language services, allowing for easy consumption by editor plugins
Apache License 2.0
1.72k stars 235 forks source link

add code fixes command #661

Closed it6 closed 5 years ago

it6 commented 6 years ago

fixes #630

DanielRosenwasser commented 6 years ago

Looks sweet! I like how this just applies a quick fix if only one is available. However, I'm getting some strange behavior with carriage returns; notice the CR character:

it6 commented 6 years ago

Which OS is this? On mac I don't see the CR character. Do you have any setting in sublime to show line ending characters?

I looked at tsc response 'newText': ' bar: any;\n' which is expected with \n at the end not sure how to debug without reproducing it.

If the file doesn't have Unix line endings can you change it and see if that fixes it

it6 commented 6 years ago

I made a code change to replace CRLF & CR characters to newline characters, please see if that fixes it

it6 commented 6 years ago

Is there anything else needed for this?

stweedie commented 5 years ago

Is there any way this can make it to the released package? It's working well for me when I manually replace the files in the sublime package directory

pjerem commented 5 years ago

Since @DanielRosenwasser review has been take into account, what is blocking this PR to be merged ?

orta commented 5 years ago

TBH, looks to me like all feedback is addressed and this PR should be merged 👍