Closed rkoval closed 4 years ago
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
:x: rkoval sign now
You have signed the CLA already but the status is still pending? Let us recheck it.
@rkoval You can also set this via an environment variable like so:
# ~/.bashrc
export NODE_OPTIONS=--max_old_space_size=1024
@roblav96 Ooh nice tip! Is there an option within this plugin that will allow that env var to be scoped only to this plugin's node invocation? I don't want that to be globally in my .bashrc such that it applies to every node process that I spawn.
@rkoval When you launch sublime from the terminal, NODE_OPTIONS=--max_old_space_size=1024 subl -w ~/Project/main.ts
, I certainly wouldn't worry about throwing it in your .bashrc
, unless your node.js API projects have some major memory leaks, then you've got a whole other problem lol
@rkoval - this can't be merged until the CLA is accepted ( see https://github.com/microsoft/TypeScript-Sublime-Plugin/pull/697#issuecomment-450613518 )
Otherwise, feels reasonable to me
feel free to close then. i'm not interested in signing the CLA for such a small change. feel free to create this change on another PR though
Cool, I'll leave that for someone interested in the feature to do 👍
Hello!
I haven't been using this plugin very long because there hasn't been JavaScript support until very recently, but so far it is excellent. However, I was running into issues with tsserver running out of heap memory (I'm using it on a large project). I was able to fix it by just upping the heap size with
--max-old-space-size
, so I wanted to extend the plugin to be able to support any arbitrary arguments to pass to the node process. I believe this PR does it in a pretty succinct and usable way, though please let me know if I should make any tweaks.Thanks!