Use `os.path.relpath` on a normalized Packages base path

microsoft / TypeScript-Sublime-Plugin

IO wrapper around TypeScript language services, allowing for easy consumption by editor plugins

Apache License 2.0

1.72k stars 237 forks source link

Use `os.path.relpath` on a normalized Packages base path #734

Closed adill closed 4 years ago

adill commented 4 years ago

The previous method fails because it assumes packages_path is normalized, yet it will not be when Sublime Text is started via the subl command with a non-normalized PATH entry (i.e. PATH=z:\bin\..\tools\sublime_text)

orta commented 4 years ago

The code looks reasonable to me, and I've tested running it on my computer and popups are working fine 👍