microsoft / TypeScript-Sublime-Plugin

IO wrapper around TypeScript language services, allowing for easy consumption by editor plugins

Apache License 2.0

1.72k stars 237 forks source link

Add setting to manage word completions inhibition #739

Closed msieurtoph closed 3 years ago

msieurtoph commented 4 years ago

733#commitcomment-37663896)

This PR adds a simple setting key to switch between old and new behavior.

Default behavior is the new one. Turning setting auto_complete_inhibit_word_completions to True activates the old one.

I hope you will be OK with that.

msftclas commented 4 years ago

All CLA requirements met.

msieurtoph commented 4 years ago

Looking back to my change, I think I found a cleaner way to switch between both behaviors, and properly return api completions only. At least, I hope to ... ;)

The behavior fixed by original PR (#733) is preserved and should still work (as far as I tested it, it worked).

orta commented 3 years ago

👍🏻 I'm for this, but it will need documenting in the README first

msieurtoph commented 3 years ago

👍🏻 I'm for this, but it will need documenting in the README first

Done ;)

orta commented 3 years ago

Cool, thanks!

gcnew commented 2 years ago

Hm.. word completions are still present for me unless I change the code to sublime.INHIBIT_WORD_COMPLETIONS | sublime.INHIBIT_EXPLICIT_COMPLETIONS as you initially did.

Update:

This PR untouched works in ST3, but there is a visual glitch as Sublime tries to render the default completion, it gets closed and then the TS one renders.
Doesn't work in ST4 unless the flags are set, but the visual glitch is always present :/