search

microsoft / TypeScript-Sublime-Plugin

IO wrapper around TypeScript language services, allowing for easy consumption by editor plugins
Apache License 2.0
1.72k stars 235 forks source link

Improve typescript_tsdk lookup #748

Closed alecmev closed 4 years ago

alecmev commented 4 years ago

Fix #538

This is flawed, of course, since the server used is never updated once initialized, so gotta restart ST when switching to/from a project with a custom typescript_tsdk set, but I can't afford to spend time on a refactor to accommodate this, and this is still much better than the status quo.

msftclas commented 4 years ago

CLA assistant check
All CLA requirements met.

alecmev commented 4 years ago

@orta @DanielRosenwasser Please, take a look, this fixes the most upvoted open issue.

orta commented 4 years ago

Conceptually this looks good, I need to get a working ST3 dev env again to verify this all works before I can merge - I might have time for that tomorrow 👍

alecmev commented 4 years ago

@orta Friendly ping :wink:

orta commented 4 years ago

Thanks for the ping!

alecmev commented 4 years ago

Thank you for dedicating time to this!

orta commented 3 years ago

We reverted these changes, after looking at it we realized that the constant lookback for the tsdk could be a cross-user code eval security hole ( C:/ is writable for all users on a machine )

sahilrajput03 commented 3 years ago

We reverted these changes, after looking at it we realized that the constant lookback for the tsdk could be a cross-user code eval security hole ( C:/ is writable for all users on a machine )

What ..?

image

So how come we'll use the react jsx now, provide help please!!