Fix popup styling for Sublime Text 4xxx (backwards compatible) - Githubissues

microsoft / TypeScript-Sublime-Plugin

IO wrapper around TypeScript language services, allowing for easy consumption by editor plugins

Apache License 2.0

1.72k stars 235 forks source link

Fix popup styling for Sublime Text 4xxx (backwards compatible) #758

Closed ephemer closed 3 years ago

ephemer commented 4 years ago

Fixes #755 by accessing keys of the style object more safely. Backwards compatible with any version of Sublime Text using Python 3+

rgant commented 4 years ago

Duplicate of #757

orta commented 3 years ago

I can't tell if this was fixed upstream in ST4 because I couldn't reproduce the original bug on a build I've just downloaded (4094)

That said, I'm confirming that this still works on both ST3 and ST4, which could be enough anyway?

Screen Shot 2020-12-07 at 12 39 10 PM

orta commented 3 years ago

That said, I think we should go for https://github.com/microsoft/TypeScript-Sublime-Plugin/pull/757 which also has the validity check, so I'm going to close this out