search

microsoft / TypeScript-Vue-Starter

A starter template for TypeScript and Vue with a detailed README describing how to use the two together.
MIT License
4.45k stars 595 forks source link

Fork of vue with special type declarations still necessary? #32

Closed somombo closed 6 years ago

somombo commented 6 years ago

In Readme.md, is the following line from the instructions still necessary:

npm install https://github.com/DanielRosenwasser/vue#540a38fb21adb7a7bc394c65e23e6cffb36cd867

Or can we simply:

npm install vue

Thanks

alexaandru commented 6 years ago

I'm curious about this as well. I for one haven't used it and the example still worked fine, including type checking. Open for example src/index.ts and try adding a bogus method, foobar() or whatever and it will complain about it with:

Object literal may only specify known properties, and 'foobar' does not exist in type 'ComponentOptions<Vue, DefaultData, DefaultMethods, DefaultComputed, PropsDefinition<Rec...'.

So I guess it's no longer needed... ?

mkotlikov commented 6 years ago

https://github.com/Microsoft/TypeScript-Vue-Starter/pull/34

cyberhck commented 6 years ago

34 is closed and this issue can be closed, please do so.