search

microsoft / TypeScript-Website

The Website and web infrastructure for learning TypeScript
https://www.typescriptlang.org
Creative Commons Attribution 4.0 International
2.23k stars 1.37k forks source link

Docs: #476

Closed gonzus closed 4 years ago

gonzus commented 4 years ago

Page URL: https://www.typescriptlang.org/v2/docs/handbook/typescript-from-scratch.html

Issue: Text says Here’s the error TypeScript found but there is no error displayed after the two lines of JS code.

Recommended Fix: Add proper error as reported by TypeScript.

Browser: Tried in Chrome (80.0.3987.162) and Firefox (74.0 (64-bit)). In fact, checked the repo file packages/handbook-v1/en/tutorials/TS for the New Programmer.md and it doesn't have the expected content.

orta commented 4 years ago

Thanks, fixed with https://github.com/microsoft/TypeScript-Website/commit/69e8baca17654903b8004275adf4223d9f15159e - will be in the next deploy

gonzus commented 4 years ago

Great, but shouldn't there be an actual error listed after line 63?

orta commented 4 years ago

Not in the markdown, the code sample will be emit an error from the compiler

http://typescriptlang.org/v2/dev/twoslash