search

microsoft / TypeScript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
https://www.typescriptlang.org
Apache License 2.0
101.27k stars 12.52k forks source link

lib.d.ts: DOMImplementation.createDocument does not follow specification #14229

Closed bobappleyard closed 7 years ago

bobappleyard commented 7 years ago

The declaration of DOMImplementation in lib.d.ts includes the method:

createDocument(namespaceURI: string | null, qualifiedName: string | null, doctype: DocumentType): Document;

However, according to the DOM Specification the doctype parameter can be null. This accords with almost every use of this method that I have ever seen in JavaScript code.

bobappleyard commented 7 years ago

I assume I should place this issue with the TSJS-lib-generator. Sorry.

bobappleyard commented 7 years ago

So TSJS-lib-generator says to raise the issue here.

mhegazy commented 7 years ago

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

bondz commented 7 years ago

Microsoft/TSJS-lib-generator#205 should fix this