[typescript] dom definitions not up to date

[mjbvz]

From @yukulele on October 5, 2017 12:7

• VSCode Version: 1.16.1
• OS Version: macOS Sierra 10.12.6

Steps to Reproduce:

• Create this code in typescript file

  const elm = document.createElement('main')

• elm is typed as HTMLElement instead of HTMLMainElement

lib.dom.d.ts is not up to date

how to update it without wait for vscode update ?

Reproduces without extensions: Yes

Copied from original issue: Microsoft/vscode#35620

[mhegazy]

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

[jamOne-]

Can I fix this one as my first contribution to TypeScript?

[SimonSchick]

@jamOne- just make a PR https://github.com/Microsoft/TSJS-lib-generator

[jamOne-]

I already know it, but I don't think this change is that simple. As far as I understand this generator code, to generate interface HTMLElementTagNameMap in dom.generated.d.ts only browser.webidl.xml interfaces are used, but HTMLMainElement is in addedTypes.json file so I have to change the generator code, or am I wrong?

[SimonSchick]

Pretty sure you can just add overload to addedTypes.json.

[jamOne-]

I am not sure I understand you. Does generating interface HTMLElementTagNameMap take into account addedTypes.json?

[inad9300]

Please, have a look at the on-going progress before proceeding: https://github.com/Microsoft/TypeScript/issues/17828

[yukulele]

The following elements are affected: abbr address article aside b bdi bdo cite code dd dfn dt em figcaption figure footer header hgroup html i kbd main mark nav noscript rp rt ruby s samp section small strong sub summary sup u var wbr