microsoft / TypeScript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
https://www.typescriptlang.org
Apache License 2.0
99.84k stars 12.36k forks source link

Avoid nesting IIFE for nested namespaces #31072

Open mihailik opened 5 years ago

mihailik commented 5 years ago

Search Terms

iife namespace nest

Suggestion

Produce a single IIFE for a nested namespace, where applicable.

The point is to reduce onion-like layering in scenarios where it is both trivial and safe to do. There would still be at least 1 level of IIFE wrapping. Every aspect of runtime/semantic/scoping behaviours is preserved as in the current emit.

Example

TypeScript Playground

TypeScript JavaScript
```ts namespace A.B.C { export function some() { return 'A.B.C.some'; } } ``` ```js var A; (function (A) { var B; (function (B) { var C; (function (C) { function some() { return 'A.B.C.some'; } C.some = some; })(C = B.C || (B.C = {})); })(B = A.B || (A.B = {})); })(A || (A = {})); ```
desired JavaScript
```js var A; (function (A) { var B = A.B || (A.B = {}); var C = B.C || (B.C = {}); function some() { return 'A.B.C.some'; } C.some = some; })(A || (A = {})); ```

Use Cases

Nested IIFE can affect performance, epecially in older/constrained environments. Of course, in general case they cannot be avoided, as they create lexical scopes and may have code living in all those nesting levels.

But there are several easy-to-detect scenarios where avoiding IIFE infestation is cheap and easy:

Note that this feature only affects JS emits, but not parsing neither declaration handling.

Also, this may feel related to #447 Partial modules and output optimization, but the suggestion there is much more broad and heavy to implementation.

Here I do not suggest merging of scopes, just eliminating an easy-to-detect subset of empty scopes that have no code in them.

Non-targeted cases

  1. This feature explicitly DOES NOT suggest merging consecutive scopes, whether in one file or multiple (that may be a valid thing to do elsewhere).
  2. This feature explicitly DOES NOT suggest eliding scopes that have code in them (that would be an error, and should be tested against by a valid implementation).
  3. This feature explicitly DOES NOT intend to elide all possible scopes/layers, only a very few specific easy to check cases.

Checklist

My suggestion meets these guidelines:

mihailik commented 5 years ago

May be useful in context:

Blazingly fast parsing, part 2: lazy parsing/Skipping inner functions (V8 team discussing recent performance optimisations that work around issues caused by multiple nested IIFE)

Each reparse adds at least the cost of parsing the function. Each reparse adds at least the cost of parsing the function