checkJs should recognize properties assigned with lodash

kevinszuchet commented 5 years ago

Search Terms

js, lodash, properties

Suggestion

Recognize properties of some object when using lodash assign method

Use Cases

Any initalization of an object using:

_.assign(obj, { ...someProps });

// Instead of
this.oneProp = oneProp;
this.anotherProp = anotherProp;

Examples

Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[ ] This could be implemented without emitting different JS based on the types of the expressions
[ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

nmain commented 5 years ago

From what I know, this would be difficult to implement because typescript has no notion of a function call modifying the type of a passed argument by mutating the argument.

IllusionMH commented 5 years ago

For these simple cases you can use parameter properties

http://www.typescriptlang.org/play/index.html#code/MYGwhgzhAEDyB2BTAwuK0DeBYAUNf0wA9vBAC4BOArsGURQBQAOVARiAJbDQmIAKFIkwBc0MPACeAGmgt2XHmQAWiCgKGjxEgJSYAvrgLQAtomVEAJg13Y8RghTNUK8aMo4QAdL3VNoAQgBeQLclD29lVV8AbkMCAxw9IA

kevinszuchet commented 5 years ago

For these simple cases you can use parameter properties

http://www.typescriptlang.org/play/index.html#code/MYGwhgzhAEDyB2BTAwuK0DeBYAUNf0wA9vBAC4BOArsGURQBQAOVARiAJbDQmIAKFIkwBc0MPACeAGmgt2XHmQAWiCgKGjxEgJSYAvrgLQAtomVEAJg13Y8RghTNUK8aMo4QAdL3VNoAQgBeQLclD29lVV8AbkMCAxw9IA

Thanks for answer!

I know, but the fact is that I don't want to change all my constructors for avoid the checkJs errors on VS Code @IllusionMH

microsoft / TypeScript