microsoft / TypeScript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
https://www.typescriptlang.org
Apache License 2.0
100.19k stars 12.38k forks source link

Performance regression in #33473 #36565

Open amcasey opened 4 years ago

amcasey commented 4 years ago

The extra work done in #33473 is valuable, but maybe it doesn't need to be so expensive. In this particular case, there don't seem to be any errors (though there is one @ts-ignore).

Setup:

  1. Clone https://github.com/amcasey/material-ui.git
  2. Check out Benchmark
  3. yarn to restore packages
  4. yarn typescript to prebuild and run some TS tests

Repro

  1. tsc -p docs

On a random Mac Mini:

Note: to build old TS commits, you probably need to change const { default: chalk } to const chalk in scripts/build/utils.js.

amcasey commented 4 years ago

FYI @weswigham