Closed mjbvz closed 3 years ago
mjbvz
commented
3 years ago Root cause seems to be that I had the following folder structure:
projects/
node_modules/
typescript/
ts-lib-problem/ # folder I had open
node_modules/
typescript/However I had explicitly opened just the ts-lib-problem folder in VS Code so I was really confused as to where the other lib types were coming from
andrewbranch
commented
3 years ago If I understand correctly, this is probably still a bug? Even if you were accidentally resolving to the wrong TypeScript installation, the folder you had opened should be a ConfiguredProject and shouldn’t pull in random lib files, right?
mjbvz
commented
3 years ago Yes, this behavior is very strange to me.
We already have logic in place to prevent the TSServer from finding tsconfig files outside the project root. Perhaps we should do the same for d.ts files?
andrewbranch
commented
3 years ago I mean, there has to be some positive reason for a .d.ts file to get pulled into a program in the first place, and without watching it happen, I can’t think of what that would be in this case.
andrewbranch
commented
3 years ago @mjbvz hmm, I can’t seem to reproduce this. Does it still repro for you?
mjbvz
commented
3 years ago I can't repo this anymore. Not sure what caused the initial issue
TypeScript Version: 4.2.0-dev.20201211
Search Terms:
Code
index.tsObject.valuesis allowed to be referenced even through thelibis set to["es5"]Expected behavior: This should be an error since
Object.valuesis not included in thees5Actual behavior: No error and go to definition opens up
es2017.d.tHere's my server log
Playground Link:
Related Issues: