Open lwschan opened 3 years ago
/needsMoreInfo
Please run the Extension Bisect command to determine whether these are coming from an extension you added (you didn't list these in your report). If Bisect identifies an extension, report the issue to the extension author. The "Report Issue" dialog on the "Help" menu can assist with that. Then close this issue, and optionally link it to the one you created on the extension's repository.
Hi @gjsjohnmurray
I just ran it with Extension Bisect, and the issue is still there.
/assign @mjbvz - is this one for you, seeing as the problems appear to be reported by the builtin ts extension?
Please provide a minimal sample project and specific steps to reproduce the problem
Hi @mjbvz
You can use the project I in first comment. just create a new .js file inside src folder, that is already good enough to trigger the problem to appear. Or do you need something more simple than that?
In the repo I shared, you can use the branch "reboot" to reproduce the problem.
yarn install
after checkout to reboot branchThen the problems will pop up. If creating 1 file does not trigger it, you can create more files in the folder you have created, or create new folders and new files to trigger it.
Please provide a minimal project. The project you linked to is quite large and this type of bug is often a project configuration issue. It's not a good use of our time to try debugging through it
Thanks the for reply, @mjbvz
I will try to provide one.
I actually specifically mentioned the reboot branch, because that branch is new, and it only has the bare minimum Gatsby startup code, with Airbnb's ESLint packages.
If you look at the main vs reboot, you will find that reboot is much smaller.
Hi @mjbvz
I have been able to reliably reproduce the problem using this new minimal project - lewisgauss/reproduce-jsconfig-error
I also have a much simpler way to reproduce it.
I hope this helps!
I followed those steps but this does not reproduce for me in VS Code insiders with extensions disabled
@mjbvz did you do npm install before going through the steps?
You also have to wait for the initializing JS/TS feature to finish in between steps.
I have just tried this on a completely different computer, and I could reproduce it. (macOS and Windows 10) With all extensions disabled. :)
Another run with Extension Bisect.
Yes node modules are installed and initialization is done.
node_modules\defer-to-connect\dist\index.d.ts
exist and are there any errors in it?Hi @mjbvz , yes, the file is there, and TSLint does not show any error. You can see it from the recording below, which shows the reproducible steps and the file without error.
https://user-images.githubusercontent.com/8966669/108243721-5c6c6d00-7189-11eb-8303-993b96864aad.mp4
Thanks but I am still not able to reproduce following those steps. Can you try collecting the logs from reproducing this:
"typescript.tsserver.log": "verbose",
TypeScript: Open TS Server log
commandThis should open a large log file called tsserver.log
⚠️Warning: The TypeScript log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on Github, just let me know and we can arrange something else. On our side, we only use these logs to investigate issues like this
Ok, I've moved this to typescript to see if they have any insights.
Here's the relevant diagnostics that are being generated:
Info 269 [02:01:03.214] event:
{"seq":0,"type":"event","event":"projectLoadingFinish","body":{"projectName":"c:/Users/LewChan/Documents/Projects/reproduce-jsconfig-error/jsconfig.json"}}
Info 270 [02:01:03.230] event:
{"seq":0,"type":"event","event":"configFileDiag","body":{"triggerFile":"c:/Users/LewChan/Documents/Projects/reproduce-jsconfig-error/jsconfig.json","configFile":"c:/Users/LewChan/Documents/Projects/reproduce-jsconfig-error/jsconfig.json","diagnostics":[{"text":"File 'c:/Users/LewChan/Documents/Projects/reproduce-jsconfig-error/node_modules/defer-to-connect/dist' not found.","code":6053,"category":"error"},{"text":"File 'c:/Users/LewChan/Documents/Projects/reproduce-jsconfig-error/node_modules/dotenv/types' not found.","code":6053,"category":"error"},{"text":"File 'c:/Users/LewChan/Documents/Projects/reproduce-jsconfig-error/node_modules/tsconfig-paths/lib/index' not found.","code":6053,"category":"error"}]}}
many modules simplify the path of types
package.json
{
"types": "dist"
}
fix it
package.json
{
"types": "dist/index.d.ts"
}
or exclude this module
jsconfig.json
"typeAcquisition": {
"exclude": ["defer-to-connect"]
}
but this is not the perfect solution
Here is a link to a working solution on stackoverflow The solution requires adding the json schema to vscode JSON Settings https://stackoverflow.com/questions/61287127/vscode-shows-typescript-related-problems-in-jsconfig-json-file#answer-66552275
Here is a link to a working solution on stackoverflow The solution requires adding the json schema to vscode JSON Settings https://stackoverflow.com/questions/61287127/vscode-shows-typescript-related-problems-in-jsconfig-json-file#answer-66552275
I tried this, sadly it doesn't work for me.
@lewisgauss Restart your VS Code after updating the JSON Schema Settings to confirm.
@lewisgauss Restart your VS Code after updating the JSON Schema Settings to confirm.
Yeah, I did that, but the error comes back after I add a new JS file.
@lewisgauss Restart your VS Code after updating the JSON Schema Settings to confirm.
Yeah, I did that, but the error comes back after I add a new JS file.
Okay
TS Template added by @mjbvz
TypeScript Version: 4.1.5
Search Terms
Steps to Reproduce:
The jsconfig.json file contains this:
Does this issue occur when all extensions are disabled?: Yes