capitalization of es2017 in error message does not match capitalization of ES2017 autocomplete suggestion

[hamirmahal]

If the maintainers of this repository think this issue is worth considering, I would like to contribute the fix for it.

Bug Report

🔎 Search Terms

"capital ES" "capitalization ES"

🕗 Version & Regression Information

• This is the behavior in every version I tried, and I reviewed the FAQ for entries about capitalization.

⏯ Playground Link

Playground link with relevant code

💻 Code

const myObj = {};
Object.values(myObj);

with "Target:" set to a pre-ES2017 example, like ES5.

🙁 Actual behavior

On hover, the error message says, "Property 'values' does not exist on type 'ObjectConstructor'. Do you need to change your target library? Try changing the lib compiler option to 'es2017' or later.(2550)"

The capitalization in this error message does not match the auto-generated capital "ES2017" suggestion in VSCode when filling out the lib compiler option.

🙂 Expected behavior

For consistency, I think the error message should say, "Property 'values' does not exist on type 'ObjectConstructor'. Do you need to change your target library? Try changing the lib compiler option to 'ES2017' or later.(2550)", instead.

Here, the capital "ES2017" matches the suggested "ES2017" that appears when typing in a tsconfig.json file in VSCode.

[DanielRosenwasser]

The change would either be to our error messages, or to the schemastore config: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/tsconfig.json

Either capitalization works - but I'm split on which would be "better" 😄

[hamirmahal]

Ha, either capitalization works for me, too.

I have a fix for this issue, but I think this issue has to have the "backlog" milestone before I can create a pull request for it.

[RyanCavanaugh]

Happy to take a PR on this one. Thanks!

[hamirmahal]

You're welcome!