Type predicate assertion does not carry over when used in another function

[yogiduzit]

Bug Report

🔎 Search Terms

• predicate
• type predicate
• type predicate return

🕗 Version & Regression Information

• This is NOT a crash
• This changed between versions __ and ___
• This is the behavior in every version I tried, and I reviewed the FAQ for entries about _____
• I was unable to test this on prior versions because ___

⏯ Playground Link

Playground link with relevant code

💻 Code

interface Animal {
  name: string;
}

interface Bird extends Animal {
  wingSpan: string;
}

/**
 * Asserts that an animal is of type T if condition is true for that animal.
 */
function isAnimalOfType<T extends Animal>(animal: Animal, condition: (animal: T) => boolean): animal is T {
  return condition(animal as T);
}

function isBird(animal: Animal) {
  return isAnimalOfType<Bird>(animal, (bird) => Boolean(bird.wingSpan));
}

function getWingspan(bird: Bird) {
  return bird.wingSpan;
}

const animals = [{ name: "a" }, { name: "a", wings: "3ft" }] as Animal[];

function checkAnimals(animals: Animal[]) {
  return animals.map(animal => {
    console.log(animal);
    if (isBird(animal)) {
      console.log(getWingspan(animal));
    }
  })
}

🙁 Actual behavior

The call to getWingspan shows an error saying Argument of type 'Animal' is not assignable to parameter of type 'Bird'.

🙂 Expected behavior

The function isAnimalOfType already asserts that the Animal will be of type T. So, why does isBird not automatically assert that?

[fatcerberus]

Type predicates are not automatically inferred. You need to explicitly declare isBird as returning animal is Bird.

[jcalz]

Duplicate of #10734

[typescript-bot]

This issue has been marked as a 'Duplicate' and has seen no recent activity. It has been automatically closed for house-keeping purposes.

[danvk]

This was marked as a duplicate of #10734, which was closed by #57465. But that PR only let "identifier" type predicates flow, not assertion predicates. The example in this issue is still broken.

This specific issue would be fixed by #58495, see playground.