Autocompletion did not work when the cursor was placed before the constructor()

[WayneCYChang]

TS Template added by @mjbvz

TypeScript Version: 5.0.1

Search Terms

• completion /
• suggest / suggestions
• IntelliSense

See https://github.com/microsoft/TypeScript/issues/53124#issuecomment-1457338704 for minimal repo

---

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version:

  
  Version: 1.75.1 (user setup)
  Commit: 441438abd1ac652551dbe4d408dfcec8a499b8bf
  Date: 2023-02-08T21:32:34.589Z
  Electron: 19.1.9
  Chromium: 102.0.5005.194
  Node.js: 16.14.2
  V8: 10.2.154.23-electron.0
  OS: Windows_NT x64 10.0.22000
  Sandboxed: No
  

• OS Version:

  
  Windows 11 21H2
  

Description

Autocompletion did not work when the cursor was placed before the constructor()

Reproduction

Steps to reproduce the behavior:

1. Go to 'the line before constructor(private service: Service)'
2. Type 'a = this.service.'
3. Autocompletion list doesn't show the method of service.

Expected behavior

Show method of service.

Screenshots

If applicable, add screenshots to help explain your problem.

Anything else relevant?

https://github.com/angular/vscode-ng-language-service/issues/1866#issue-1596155750

[mjbvz]

Please share a minimal, self-contained code example that demonstrates this issue

[WayneCYChang]

Please share a minimal, self-contained code example that demonstrates this issue

Thanks for the quick reply. Here is the code example. https://github.com/WayneCYChang/vscode-autocomplete-wrong

[mjbvz]

Thanks. Minimal repo:

class Foo {
    bar = this.foo // Type . here
    constructor(private foo: Foo) { }
}

[mjbvz]

Suggestions do start working after the first letter is typed. It's likely they are just broken while the file is in an invalid syntax state

[WayneCYChang]

Yes, you're right. An invalid syntax state is broken Suggestions. But I also found that is only broken before the constructor(). The suggestions will work normally if you have some words between '.' and the constructor().

I have committed a new code to the repo. You can try it out.

[Andarist]

The issue is not specific to the constructor. The same happens here:

class Foo {
    bar = this.
    other;
}

The parser continues to parse this as a property access so it doesn't parse other (or constructor in the other example) as a class member (or constructor). Thus the symbols for those members are not created.

In its essence the issue is very very similar to the one reported here