Open RyanCavanaugh opened 1 year ago
Excess property checking has been a fairly successful effort to date, able to catch a huge percentage of typos and misapprehensions while not implying a new kind of type.
Counterpoint: EPC has been so successful that people are regularly surprised when it turns out to not be part of the type system proper, as evidenced by many, many issues where people treat it as a de facto implementation of exact types and report it as a bug when that use case falls over.
Actual code used in https://github.com/fastify/fastify/pull/4823 to generate a union of 500 numbers. Could easily generate a union of a million or more numbers:
type StringAsNumber<T extends string> = T extends `${infer N extends number}` ? N : never;
type CodeClasses = 1 | 2 | 3 | 4 | 5;
type Digit = 0 |1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9;
type HttpCodes = StringAsNumber<`${CodeClasses}${Digit}${Digit}`>;
That same Fastify issue also shows the usefulness for HTTP Status Codes: To type the expected value sent by a router depending on the status code set by that router and enabling setting a response format for not just specific HTTP codes but for eg all 2xx, 4xx or 5xx errors and thus have 4xx
match against any value between 400
and 499
doProbability(Math.random() * 200); // Well, we tried.
FWIW I'd expect this to fail to be useful for uint8 / ... / uint32 scenarios.
As in, fail not because we can prove it's outside the 0..1 range, but because it has type number
which should be considered not compatible with any integer type ever unless it's either a 1) constant (in which case it will have a specific literal type which is compatible with range) or 2) explicitly casted away from number
by user.
I know this will be inconvenient for doing any kind of arithmetic operations on such numbers - e.g. x * 2
is obviously outside the range and, unless TS will want to do the complexity of encoding all possible even numbers, the result will have type number
instead of a range value. But in a sense that's the point - values should be in range only if they were explicitly casted to said range (or if TS can prove for ops like (x | 0): i32
).
FWIW I'd expect Exclude
to be equivalent to the union (for example Exclude<0..32767, 5> = 1..4 | 6..32767
(inclusive ranges))
This seems much better than the particular option 1 | 2 | 3 | 4 | 6 | 7 | ... | 32765 | 32766 | 32767
Theoretically a union of ranges is never larger than the equivalent union of each number represented.
Edit:
An additional note is that TS currently errors here:
type u1 = 0 | 1
let check1: u1 = Math.round(Math.random()) // error
let check2: u1 = 0 + 1 // error
let check3: u1 = 1 * 1 // error
Since 0 | 1
is equivalent to the range, that means some implementation of numeric operators can happen before implementing ranges, and it would still affect code. (I can see check2 and check3 validating, although check1 seems like a stretch.)
This divides the "operators" part of the problem into two smaller parts.
We could protect against mistakes like if (Math.random() > 1), for sure, though in 150ish comments this wasn't brought up.
@bradzacher reported my ts-eslint wish over there for such similar checks:
indexOf() >= -1
- "error - expression is always true"I'm really happy that this is being considered; this is a really really important feature to me. API documentation is a big reason why, and checking literal inputs by itself would be a big improvement for me, but I urge you to make ranges a full type system.
You talk about the complexity of type AnyUInt16But5 = Exclude<0..32767, 5>;
But would it be worth it to just... not support that? Simplify it to 0..32767
? Maybe give an error message?
TypeScript already does this:
I also wouldn't mind 0..3
being treated slightly differently from 0 | 1 | 2 | 3
. Simply having the feature at all would be a huge boon to me.
There are just a lot of advantages for having this be more fully a part of the type system. For instance, passing an untrusted input number to a function expecting an integer within a range would be a useful opportunity for a reminder to validate the input.
Good day. I red fastify example and completed trim type challenge and discover, that wide IntRange type can done in vanilla typescript, playground.
@phpcoder2022 I do not think your example works the way people would like this feature to: for example.
@CamJN Hello. I completed your problem. May be my solution is some verbose, but these types and funcs were should write only once.
Feature Update: Numeric Ranges
This is a Feature Update for #15480.
What's the Proposal?
The general idea is that you'd be able to write a type which represents a range of numbers, e.g.
0..15
to represent an integer in the range[0, 15]
, or0...1
to represent a real number in the range[0, 1)
, or even characters as well, e.g."a".."d"
would be"a" | "b" | "c" | "d"
Scenarios
Listed scenarios in the original thread
Math.random()
result, floating point 0 (inclusive) to 1 (exclusive)"b" | "c" | "d"
(no scenario given)UInt8
and friendsScenario Discussion
First, we need to make a distinction between static (i.e. hardcoded) and dynamic (i.e. computed) data.
Validation of certain static inputs can make a lot of sense here. I think every programmer has encountered an API that they thought took an integer 0-255 value, but actually took a 0-1.0, or vice versa. Scenarios like "opacity is specified as a percentage, not an alpha channel value" make a ton of sense, especially since those sorts of values are reasonably likely to be hardcoded, and mistakes here can be subtle.
Same goes for something like JavaScript's
Date
's infamousmonth
behavior, where 0 is January and 11 is December. Unfortunately, even in an ideal world, unless you happened to be specifying something like2024, 12, 25
, it's unlikely to be caught by a range-based checking approach.Some other scenarios seem a bit overclever, or don't seem to correspond to a scenario where the checker is even active. HTTP Status Codes have ranges, to be sure, but the use case is what, exactly? Either your transport library is sorting these things out ahead of time for you, or it's not, in which case it's not going to neatly correspond to a discriminated union. Sudoku values are opaque tokens, not numbers in any meaningful sense.
Many of these scenarios don't seem to correspond to any static scenario. For example, it seems unlikely that you have a nontrivial number of geographic coordinates hardcoded into your program.
Validation of dynamic inputs is where things get a bit weird here.
In an output position, e.g.
Math.random()
returning a number0 <= n < 1
, this seems like information of somewhat limited utility which might be better presented as a documentation comment on the function. We could protect against mistakes likeif (Math.random() > 1)
, for sure, though in 150ish comments this wasn't brought up.In a dynamic input position, the feature implies new kinds of narrowing, as well as some higher-order reasoning that doesn't exist right now. For example, here, we'd need to bound
n
first to[0, Infinity)
, then[0, 2)
, then have some suitable representation of whatMath.floor
does to its input (further implying that it's generic).People will of course want to use
Math.max
/Math.min
to create these bounds:So there's also need of a representation of what
max
andmin
do.This implies type constructors for:
-4.5 | 0
is-4
)Math.floor(-4.5)
is-5
)Other Problems
Floating vs Integer, Inclusive vs Exclusive Bounds
There was a fair amount of discussion in the original issue basically saying, this should obviously just be for integers, because floats are too hard to deal with, and also, this should obviously just be for floats, and then there should be an intersectable
int &
type to cause any float-based range to become integral.Suggestions here have hinted that that
0..1
(a percentage) is a float between 0 and 1, end-inclusive0..1
(Math.random
result) is a float between 0 and 1, end-exclusive0..255
is an int between 0 and 255But these can't all be true at once; either
0..1
is0
,0 | 1
, or[0, 1]
, or[0, 1)
. It can't be all of them. Similarly,0..255
is either0 | ... | 255
,0 | ... | 254
,[0, 255]
, or[0, 255)
.There have also been proposals for separate float/integral/arbitrary-step syntax, as well as separate endpoint syntax. It doesn't seem likely, at all, that someone seeing
0..16
will immediately know which is happening.Union vs Non-finite Representation
Many comments in the original issue stipulated that this should "just" be sugar for expanding into a union type, e.g.
0..2
is0 | 1 | 2
, orRange<0, 30, 10>
should "just" be sugar for0 | 10 | 20 | 30
.This points to a number of very difficult problems which I think render this feature nearly completely intractable given how unions work today.
Today, you can already write
0 | 1 | 2
. You can, in fact, write very large unions, and we've done a ton of work to optimize those unions as best we can. The impracticality of writing out the union from0
to255
is a good counterweight to the performance implications of doing so.But the scenarios in the original issue are often around places where that union expansion would instantly cause TypeScript to run out of memory. This isn't something trivially avoidable, either. If you write something like
the resulting type is necessarily a) an intersection of a range and a negated type, neither of which we have yet, b) a union of 32766 members, or c) a new kind of type constructor in addition to negated types.
The implied confusion by
0 | 1 | 2
being a completely different beast from0..2
, even though by necessity you would only be writing the latter if the former didn't work, seems nearly insurmountable. Why shouldn't they be identical? It's very, very hard to justify. A feature that seems to want to work one way for small numbers and another way for large numbers sets off a lot of red flags.Complexity
New type constructors are, by far, the most expensive thing we can do in TypeScript in terms of implementation complexity. Each new way to construct a type adds to the matrix of higher-order reasoning we have to implement in order to make generics and type relationships work. The scenarios as described require somewhere between 2 and 6. Mapped types was 1, conditional types was 1, string enums was 1, etc. -- the complexity spend here is quite high just in rough terms.
Possible Next Step?
It broadly seems like 90%+ of the value in this feature lies in the checking of static values, but 90%+ of the complexity, if not more, lies in the checking of dynamic values, plus the complexity of how this feature would work with existing type concepts like literal unions.
The logical outcome of "Well just check static values, then" of this is unsatisfying, to say the least:
Excess property checking has been a fairly successful effort to date, able to catch a huge percentage of typos and misapprehensions while not implying a new kind of type. I'm curious if we could support JSDoc-based range checking which only fires on literal inputs:
This would cleanly position the feature outside the type system, possibly even as an editor-only feature like
@deprecated
. This also fits in well with regex types (#41160), where an entire type system feature seems like overkill for something where the primary use case is to notify you right away if you just typed an out-bounds literal value.