search

microsoft / TypeScript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
https://www.typescriptlang.org
Apache License 2.0
101.26k stars 12.52k forks source link

Stub out copilotRelated command #60488

Closed sandersn closed 2 weeks ago

sandersn commented 2 weeks ago

This feature didn't help, but it took a long time to verify that. The copilotRelated command will return an empty array in 5.7, and should be removed entirely in Typescript 5.8.

The only client should be VSCode 1.95. Matching PR to remove it from the typescript extension: https://github.com/microsoft/vscode/pull/233729.

typescript-bot commented 2 weeks ago

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, @zkat, and @joj for you. Feel free to loop in other consumers/maintainers if necessary.

typescript-bot commented 2 weeks ago

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

sandersn commented 2 weeks ago

@typescript-bot cherry-pick this

sandersn commented 2 weeks ago

@typescript-bot cherry-pick

sandersn commented 2 weeks ago

@typescript-bot cherry-pick to release-5.7

typescript-bot commented 2 weeks ago

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick to release-5.7 ✅ Started ✅ Results
typescript-bot commented 2 weeks ago

Hey, @sandersn! I've created #60495 for you.