Always use `nonFixingMapper` in `instantiateSignatureInContextOf`

Andarist commented 2 days ago

fixes https://github.com/microsoft/TypeScript/issues/60552

I'm not exactly sure if this is right but the presented issue shows how the current logic can lead to surprising results. The existing test cases are fairly OK with this change, it would be great to run the extended test suite to learn what kind of unwanted effects this change might have (cc @jakebailey )

jakebailey commented 2 days ago

I do like running tests

@typescript-bot test it

typescript-bot commented 2 days ago

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot commented 2 days ago

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot commented 2 days ago

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60557/merge:

Something interesting changed - please have a look.

Details

effect

typescript-bot commented 2 days ago

@jakebailey Here are some more interesting changes from running the user tests suite

Details

fp-ts

### [tsconfig.json](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/tsconfig.json) - [NEW] `error TS2345: Argument of type 'ReaderTaskEither<{ a: string; }, string, number>' is not assignable to parameter of type 'ReaderTaskEither<{ b: number; }, string, number>'.` - [dtslint\/ReaderTaskEither.ts\#L161](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L161) - [dtslint\/ReaderTaskEither.ts\#L187](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L187) - [dtslint\/ReaderTaskEither.ts\#L234](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L234) - [dtslint\/ReaderTaskEither.ts\#L260](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L260) - [NEW] `error TS2578: Unused '@ts-expect-error' directive.` - [dtslint\/ReaderTaskEither.ts\#L162](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L162) - [dtslint\/ReaderTaskEither.ts\#L188](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L188) - [dtslint\/ReaderTaskEither.ts\#L235](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L235) - [dtslint\/ReaderTaskEither.ts\#L261](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L261) ### [dtslint\/tsconfig.json](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/tsconfig.json) - [NEW] `error TS2345: Argument of type 'ReaderTaskEither<{ a: string; }, string, number>' is not assignable to parameter of type 'ReaderTaskEither<{ b: number; }, string, number>'.` - [dtslint\/ReaderTaskEither.ts\#L161](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L161) - [dtslint\/ReaderTaskEither.ts\#L187](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L187) - [dtslint\/ReaderTaskEither.ts\#L234](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L234) - [dtslint\/ReaderTaskEither.ts\#L260](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L260) - [NEW] `error TS2578: Unused '@ts-expect-error' directive.` - [dtslint\/ReaderTaskEither.ts\#L162](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L162) - [dtslint\/ReaderTaskEither.ts\#L188](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L188) - [dtslint\/ReaderTaskEither.ts\#L235](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L235) - [dtslint\/ReaderTaskEither.ts\#L261](https://github.com/gcanti/fp-ts/blob/669cd3ed7cb5726024331a7a1cf35125669feb30/dtslint/ReaderTaskEither.ts#L261)

typescript-bot commented 2 days ago

@jakebailey The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,640k (± 0.76%)}	_{193,096k (± 0.08%)}	_~	_193,005k	_193,410k	_{p=0.810 n=6}
_{Parse Time}	_{1.31s (± 0.89%)}	_{1.31s (± 0.96%)}	_~	_1.29s	_1.32s	_{p=0.801 n=6}
_{Bind Time}	_0.72s	_{0.72s (± 0.57%)}	_~	_0.71s	_0.72s	_{p=0.405 n=6}
_{Check Time}	_{9.84s (± 0.35%)}	_{9.79s (± 0.39%)}	_{-0.05s (- 0.49%)}	_9.74s	_9.84s	_{p=0.036 n=6}
_{Emit Time}	_{2.72s (± 0.55%)}	_{2.73s (± 0.28%)}	_~	_2.72s	_2.74s	_{p=0.318 n=6}
_{Total Time}	_{14.58s (± 0.30%)}	_{14.54s (± 0.31%)}	_~	_14.48s	_14.59s	_{p=0.089 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,937	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,955	_410,959	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,226,009k (± 0.00%)}	_{1,225,996k (± 0.00%)}	_~	_1,225,949k	_1,226,066k	_{p=0.689 n=6}
_{Parse Time}	_{6.65s (± 0.64%)}	_{6.64s (± 0.78%)}	_~	_6.59s	_6.70s	_{p=0.809 n=6}
_{Bind Time}	_{1.89s (± 0.22%)}	_{1.88s (± 0.56%)}	_~	_1.87s	_1.90s	_{p=0.528 n=6}
_{Check Time}	_{31.93s (± 0.44%)}	_{31.92s (± 0.57%)}	_~	_31.65s	_32.09s	_{p=0.936 n=6}
_{Emit Time}	_{15.22s (± 0.34%)}	_{15.21s (± 0.26%)}	_~	_15.15s	_15.27s	_{p=0.935 n=6}
_{Total Time}	_{55.68s (± 0.23%)}	_{55.66s (± 0.41%)}	_~	_55.35s	_55.84s	_{p=0.809 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,499,513	_2,499,513	_~	_~	_~	_{p=1.000 n=6}
_Types	_909,291	_909,291	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,317,335k (± 0.00%)}	_{2,317,326k (± 0.00%)}	_~	_2,317,273k	_2,317,383k	_{p=0.689 n=6}
_{Parse Time}	_{9.25s (± 0.19%)}	_{9.25s (± 0.20%)}	_~	_9.22s	_9.27s	_{p=0.685 n=6}
_{Bind Time}	_{2.16s (± 0.74%)}	_{2.16s (± 0.68%)}	_~	_2.14s	_2.18s	_{p=1.000 n=6}
_{Check Time}	_{75.07s (± 0.57%)}	_{74.79s (± 0.36%)}	_{-0.28s (- 0.37%)}	_74.54s	_75.31s	_{p=0.045 n=6}
_{Emit Time}	_{0.29s (± 1.92%)}	_{0.28s (± 3.64%)}	_~	_0.27s	_0.30s	_{p=0.663 n=6}
_{Total Time}	_{86.77s (± 0.49%)}	_{86.49s (± 0.30%)}	_{-0.28s (- 0.33%)}	_86.25s	_87.00s	_{p=0.045 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,251	_1,225,276	_{+25 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,545	_266,550	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,354,196k (± 0.01%)}	_{2,414,811k (± 6.13%)}	_~	_2,353,747k	_2,717,488k	_{p=0.471 n=6}
_{Parse Time}	_{5.21s (± 0.61%)}	_{5.23s (± 1.25%)}	_~	_5.17s	_5.36s	_{p=1.000 n=6}
_{Bind Time}	_{1.78s (± 1.05%)}	_{1.77s (± 1.27%)}	_~	_1.74s	_1.79s	_{p=0.566 n=6}
_{Check Time}	_{35.27s (± 0.32%)}	_{35.11s (± 0.43%)}	_~	_34.83s	_35.23s	_{p=0.066 n=6}
_{Emit Time}	_{2.95s (± 1.49%)}	_{2.99s (± 1.05%)}	_~	_2.94s	_3.03s	_{p=0.077 n=6}
_{Total Time}	_{45.23s (± 0.29%)}	_{45.12s (± 0.18%)}	_~	_44.98s	_45.21s	_{p=0.148 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,251	_1,225,276	_{+25 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,545	_266,550	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,908,165k (±12.85%)}	_{3,149,364k (± 0.01%)}	_~	_3,148,606k	_3,149,703k	_{p=0.575 n=6}
_{Parse Time}	_{6.98s (± 1.89%)}	_{7.00s (± 0.85%)}	_~	_6.94s	_7.09s	_{p=1.000 n=6}
_{Bind Time}	_{2.16s (± 1.61%)}	_{2.12s (± 1.35%)}	_~	_2.08s	_2.16s	_{p=0.092 n=6}
_{Check Time}	_{42.66s (± 0.60%)}	_{42.73s (± 0.31%)}	_~	_42.62s	_42.97s	_{p=0.471 n=6}
_{Emit Time}	_{3.47s (± 2.09%)}	_{3.52s (± 1.31%)}	_~	_3.46s	_3.58s	_{p=0.199 n=6}
_{Total Time}	_{55.26s (± 0.68%)}	_{55.38s (± 0.30%)}	_~	_55.16s	_55.68s	_{p=0.520 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,223	_262,223	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,606	_106,607	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{439,769k (± 0.01%)}	_{439,795k (± 0.01%)}	_~	_439,737k	_439,833k	_{p=0.471 n=6}
_{Parse Time}	_{3.55s (± 1.81%)}	_{3.55s (± 0.68%)}	_~	_3.52s	_3.59s	_{p=0.628 n=6}
_{Bind Time}	_{1.32s (± 1.70%)}	_{1.32s (± 0.31%)}	_~	_1.31s	_1.32s	_{p=0.548 n=6}
_{Check Time}	_{18.99s (± 0.39%)}	_{18.98s (± 0.40%)}	_~	_18.88s	_19.09s	_{p=1.000 n=6}
_{Emit Time}	_{1.52s (± 1.02%)}	_{1.51s (± 0.69%)}	_~	_1.50s	_1.53s	_{p=0.621 n=6}
_{Total Time}	_{25.39s (± 0.51%)}	_{25.37s (± 0.33%)}	_~	_25.24s	_25.50s	_{p=0.936 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,669k (± 0.03%)}	_{371,694k (± 0.04%)}	_~	_371,553k	_371,967k	_{p=1.000 n=6}
_{Parse Time}	_{2.91s (± 0.86%)}	_{2.89s (± 1.16%)}	_~	_2.84s	_2.94s	_{p=0.294 n=6}
_{Bind Time}	_{1.59s (± 1.03%)}	_{1.60s (± 1.50%)}	_~	_1.57s	_1.63s	_{p=0.411 n=6}
_{Check Time}	_{16.48s (± 0.32%)}	_{16.50s (± 0.23%)}	_~	_16.46s	_16.55s	_{p=0.746 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=1.000 n=6}
_{Total Time}	_{20.97s (± 0.28%)}	_{20.98s (± 0.19%)}	_~	_20.94s	_21.04s	_{p=0.687 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,163,934	_3,163,934	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,090,167	_1,090,167	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,244,420k (± 0.02%)}	_{3,244,419k (± 0.02%)}	_~	_3,243,742k	_3,244,838k	_{p=0.810 n=6}
_{Parse Time}	_{14.08s (± 0.72%)}	_{14.07s (± 0.52%)}	_~	_13.96s	_14.17s	_{p=1.000 n=6}
_{Bind Time}	_{4.58s (± 2.51%)}	_{4.50s (± 0.44%)}	_~	_4.47s	_4.52s	_{p=0.252 n=6}
_{Check Time}	_{88.31s (± 1.86%)}	_{87.92s (± 3.86%)}	_~	_85.33s	_92.36s	_{p=0.471 n=6}
_{Emit Time}	_{26.04s (± 9.46%)}	_{26.94s (± 7.93%)}	_~	_22.87s	_28.91s	_{p=0.630 n=6}
_{Total Time}	_{133.02s (± 1.21%)}	_{133.44s (± 1.86%)}	_~	_131.14s	_137.97s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,617	_288,617	_~	_~	_~	_{p=1.000 n=6}
_Types	_117,107	_117,107	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,829k (± 0.03%)}	_{440,861k (± 0.01%)}	_~	_440,804k	_440,952k	_{p=0.471 n=6}
_{Parse Time}	_{4.06s (± 0.55%)}	_{4.07s (± 1.21%)}	_~	_4.01s	_4.13s	_{p=0.627 n=6}
_{Bind Time}	_{1.75s (± 1.02%)}	_{1.74s (± 0.47%)}	_~	_1.73s	_1.75s	_{p=0.324 n=6}
_{Check Time}	_{18.88s (± 0.42%)}	_{18.87s (± 0.30%)}	_~	_18.79s	_18.96s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.69s (± 0.42%)}	_{24.69s (± 0.37%)}	_~	_24.55s	_24.81s	_{p=0.747 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₈	₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_551,583	_551,583	_~	_~	_~	_{p=1.000 n=6}
_Types	_184,808	_184,808	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{491,882k (± 0.00%)}	_{491,855k (± 0.03%)}	_~	_491,512k	_491,962k	_{p=0.173 n=6}
_{Parse Time}	_{3.41s (± 1.18%)}	_{3.40s (± 0.49%)}	_~	_3.38s	_3.42s	_{p=0.871 n=6}
_{Bind Time}	_{1.17s (± 0.90%)}	_{1.17s (± 0.70%)}	_~	_1.16s	_1.18s	_{p=0.865 n=6}
_{Check Time}	_{19.54s (± 0.38%)}	_{19.69s (± 1.50%)}	_~	_19.46s	_20.28s	_{p=0.261 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.12s (± 0.25%)}	_{24.26s (± 1.17%)}	_~	_24.03s	_24.82s	_{p=0.298 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot commented 2 days ago

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60557/merge:

Something interesting changed - please have a look.

Details

reduxjs/redux-devtools

**25 of 58 projects failed to build with the old tsc and were ignored** ### [packages\/redux-devtools\/examples\/todomvc\/tsconfig.json](https://github.com/reduxjs/redux-devtools/blob/6e400f68b3ebeb677c71bf4e39340f81484591e3/packages/redux-devtools/examples/todomvc/tsconfig.json) - `error TS2322: Type 'Func<[next: StoreEnhancerStoreCreator], StoreEnhancerStoreCreator, {}>>' is not assignable to type 'StoreEnhancer'.` - [packages\/redux-devtools\/examples\/todomvc\/src\/store\/configureStore.dev.ts\#L11](https://github.com/reduxjs/redux-devtools/blob/6e400f68b3ebeb677c71bf4e39340f81484591e3/packages/redux-devtools/examples/todomvc/src/store/configureStore.dev.ts#L11) ### [packages\/redux-devtools\/examples\/counter\/tsconfig.json](https://github.com/reduxjs/redux-devtools/blob/6e400f68b3ebeb677c71bf4e39340f81484591e3/packages/redux-devtools/examples/counter/tsconfig.json) - `error TS2322: Type 'Func<[next: StoreEnhancerStoreCreator], StoreEnhancerStoreCreator<{ dispatch: {}; }, {}>>' is not assignable to type 'StoreEnhancer'.` - [packages\/redux-devtools\/examples\/counter\/src\/store\/configureStore.dev.ts\#L20](https://github.com/reduxjs/redux-devtools/blob/6e400f68b3ebeb677c71bf4e39340f81484591e3/packages/redux-devtools/examples/counter/src/store/configureStore.dev.ts#L20)

Andarist commented 2 days ago

Redux-based repro from the reports above: TS playground. Interestingly, it actually fails to be inferred with current version and it does infer with this change... but then it fails to typecheck. The current version works because it tries out the last compose's overload which is very permissive.

fp-ts' change: TS playground. It's an error position change.

microsoft / TypeScript