search

microsoft / TypeScriptSamples

Community Driven Samples for TypeScript
3.19k stars 1.78k forks source link

Update jsx sample with current react version, modern types #144

Closed weswigham closed 7 years ago

weswigham commented 7 years ago

This sample came to my attention since our RWC test for it had an error introduced in 2.4/2.5, caused by old react definitions making the construct it was using not-typesafe. Rather than accepting the error, I thought it better to update the sample with a current version of react.

This PR removes TSD and uses @types, updates the readme to reference the npm commands, and updates the project to use react 15 (and, by extension, react-dom).

msftclas commented 7 years ago

@weswigham, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot