search

microsoft / UVAtlas

UVAtlas isochart texture atlas
https://walbourn.github.io/uvatlas-return-of-the-isochart/
MIT License
842 stars 148 forks source link

Fix warnings generated by clang #132

Closed JPeterMugaas closed 10 months ago

JPeterMugaas commented 10 months ago

Fix warnings generated by clang such as ignored pragmas and "-Wunused-but-set-variable" warnings. This also fixes a build error with uvatlastool.exe.

walbourn commented 10 months ago

/azp run UVAtlas-GitHub,UVAtlas-GitHub-Dev17,UVAtlas-GitHub-CMake,UVAtlas-GitHub-CMake-Dev17,UVAtlas-GitHub-WSL,UVAtlas-GitHub-WSL-11

azure-pipelines[bot] commented 10 months ago
Azure Pipelines successfully started running 3 pipeline(s).
walbourn commented 10 months ago

/azp run UVAtlas-GitHub,UVAtlas-GitHub-Dev17,UVAtlas-GitHub-CMake,UVAtlas-GitHub-CMake-Dev17,UVAtlas-GitHub-WSL,UVAtlas-GitHub-WSL-11

azure-pipelines[bot] commented 10 months ago
Azure Pipelines successfully started running 3 pipeline(s).
walbourn commented 10 months ago

Having some kind of problems with the build infrastructure... will commit when I get a clean test build.

walbourn commented 10 months ago

I was trying to submit this to work around the infrastructure problems, and it appears the code you changed broke DEBUG builds. Those variables were used for debug output.

JPeterMugaas commented 10 months ago

I have started thinking about this issue. I can't do anything about it until I get back on the 24th. I will follow up at https://github.com/microsoft/UVAtlas/pull/134 .