Feature request - Create stubs for public methods #11

[rCartoux]

• Generate test methods for each public method available in the selected class.
• The test methods will be placed where the new token "$TestMethods$" is specified in the file template
• New templates are available :
  • Tested object creation : code to instantiate the object to test in each test method
  • Tested object reference : name of the local variable or field of the object to test in the test method
• Added new test cases

[msftclas]

All CLA requirements met.

[RandomEngy]

Amazing! Looking into it now, but at first glance seems quite solid.

[rCartoux]

Thanks! I am thinking now about some problems I didn't see:

• When the class has methods with arguments having ref or out modifiers : does not work now, need to add local variables. Also need to check what happens if there is params keyword in the arguments
• Now content tokens are accepted and replaced in the tested object creation and reference template, which does not make sense except for $ExplicitConstructor$ in the creation one. But maybe it is a separate issue about validation in general (define and validate in the settings ui which tokens are allowed in which templates) ?

[rCartoux]

Ok thanks! will do

[RandomEngy]

You're right, the "accepted tokens" list might need a bit of shuffling around. Also https://github.com/Microsoft/UnitTestBoilerplateGenerator/wiki/Custom-Format-Tokens will need an update.

[RandomEngy]

With your latest version I'm getting an exception when trying to generate from ClassWithMethods to VSTestCases:

---

System.NotSupportedException: Parameter type not supported

at UnitTestBoilerplate.Services.TestGenerationService.GetArgumentDescriptors(List1 argumentList, SemanticModel semanticModel, MockFramework mockFramework) in D:\git\UnitTestBoilerplateGenerator\src\Services\TestGenerationService.cs:line 324 at UnitTestBoilerplate.Services.TestGenerationService.<CollectTestGenerationContextAsync>d__9.MoveNext() in D:\git\UnitTestBoilerplateGenerator\src\Services\TestGenerationService.cs:line 238 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter1.GetResult() at UnitTestBoilerplate.Services.TestGenerationService.d15.MoveNext() in D:\git\UnitTestBoilerplateGenerator\src\Services\TestGenerationService.cs:line 343 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult() at UnitTestBoilerplate.Services.TestGenerationService.d6.MoveNext() in D:\git\UnitTestBoilerplateGenerator\src\Services\TestGenerationService.cs:line 57 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult() at UnitTestBoilerplate.ViewModel.CreateUnitTestBoilerplateViewModel.d__54.MoveNext() in D:\git\UnitTestBoilerplateGenerator\src\ViewModel\CreateUnitTestBoilerplateViewModel.cs:line 181 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.GetResult() at UnitTestBoilerplate.ViewModel.CreateUnitTestBoilerplateViewModel.<b__53_0>d.MoveNext() in D:\git\UnitTestBoilerplateGenerator\src\ViewModel\CreateUnitTestBoilerplateViewModel.cs:line 166

[rCartoux]

Hi David, yes I just saw thx, I have a look

Robin

On 30 June 2018 at 14:06, David Rickard notifications@github.com wrote:

With your latest version I'm getting an exception when trying to generate from ClassWithMethods to VSTestCases:

System.NotSupportedException: Parameter type not supported

at UnitTestBoilerplate.Services.TestGenerationService. GetArgumentDescriptors(List1 argumentList, SemanticModel semanticModel, MockFramework mockFramework) in D:\git\UnitTestBoilerplateGenerator\ src\Services\TestGenerationService.cs:line 324 at UnitTestBoilerplate.Services.TestGenerationService.< CollectTestGenerationContextAsync>d9.MoveNext() in D:\git\ UnitTestBoilerplateGenerator\src\Services\TestGenerationService.cs:line 238 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter. HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime. CompilerServices.TaskAwaiter1.GetResult() at UnitTestBoilerplate.Services.TestGenerationService.d15.MoveNext() in D:\git\UnitTestBoilerplateGenerator\src\Services\TestGenerationService.cs:line 343 --- End of stack trace from previous location where exception was thrown

at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter. HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter1.GetResult() at UnitTestBoilerplate.Services.TestGenerationService.< GenerateUnitTestFileAsync>d6.MoveNext() in D:\git\ UnitTestBoilerplateGenerator\src\Services\TestGenerationService.cs:line 57 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter. HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime. CompilerServices.TaskAwaiter1.GetResult() at UnitTestBoilerplate.ViewModel.CreateUnitTestBoilerplateViewModel.d54.MoveNext() in D:\git\UnitTestBoilerplateGenerator\src\ViewModel\ CreateUnitTestBoilerplateViewModel.cs:line 181 --- End of stack trace from previous location where exception was thrown

at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter. HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.GetResult() at UnitTestBoilerplate.ViewModel.CreateUnitTestBoilerplateViewModel.<<get_ CreateUnitTestCommand>b__53_0>d.MoveNext() in D:\git\ UnitTestBoilerplateGenerator\src\ViewModel\CreateUnitTestBoilerplateViewModel.cs:line 166

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Microsoft/UnitTestBoilerplateGenerator/pull/28#issuecomment-401540145, or mute the thread https://github.com/notifications/unsubscribe-auth/AV8YZF3oy4D7PuGezXKovuZsY73VuaJ7ks5uB3fqgaJpZM4U1IK9 .

[RandomEngy]

Awesome! Can you re-run the self-test to update the expected output for the default method changes you made? And let me know when you're all done with the changes and I'll ship it.

[rCartoux]

Ok!

Unfortunately there are still some cases I need to check like arguments which are one or multidimensional arrays, params/ref/out modifiers etc

Then I ll do the test cases, maybe add some new ones. I let you know when its ready

Thx for the feedback

Cheers

On 30 June 2018 at 14:48, David Rickard notifications@github.com wrote:

Awesome! Can you re-run the self-test to update the expected output for the default method changes you made? And let me know when you're all done with the changes and I'll ship it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Microsoft/UnitTestBoilerplateGenerator/pull/28#issuecomment-401542393, or mute the thread https://github.com/notifications/unsubscribe-auth/AV8YZC1DCHppUQobsJpET7fbLOWl_WmUks5uB4GfgaJpZM4U1IK9 .

[rCartoux]

should be ok now

[RandomEngy]

Now getting this when I invoke the create unit test boilerplate option:

Nevermind, just needed to rebuild it seems. Looking good!

[RandomEngy]

Thanks again. Released with 1.9. Would you be able to also update the "tokens" wiki page? https://github.com/Microsoft/UnitTestBoilerplateGenerator/wiki/Custom-Format-Tokens

[rCartoux]

sure!

[RandomEngy]

Also a super easy way to help is rate it on the marketplace: https://marketplace.visualstudio.com/items?itemName=RandomEngy.UnitTestBoilerplateGenerator it only has a handful of reviews. There is a guy who hasn't updated his 1-star review months after I added xUnit support for him. :/

[rCartoux]

I have updated the custom format tokens page in my wiki fork : new TestMethods and TestedMethodName formats https://github.com/rCartoux/UnitTestBoilerplateGenerator-wiki

(not sure how to proceed with wiki issues / pull requests)

[RandomEngy]

I'll just copy/paste. Thanks!