microsoft / VFSForGit

Virtual File System for Git: Enable Git at Enterprise Scale
MIT License
5.98k stars 451 forks source link

Revert "GVFSVerb: Use OAuth credentials by default" #1808

Closed derrickstolee closed 7 months ago

derrickstolee commented 7 months ago

This reverts commit cbd0cefb9cc87744286fde23632860354f5c62ee. This commit was introduced in #1803 based on a comment I made recommending "faster adoption" but that was a mistake. When the release was shipped to winget yesterday, this led to breaks in some pipeline environments.

Using this authentication mode by default is breaking some automated scenarios on build agents that use "gvfs clone". Removing the new default is a fast measure to fix these users, while a longer-term consideration for increasing adoption of OAuth can be done at a later date with the proper parties engaged.

derrickstolee commented 7 months ago

(Please ignore the confusion between commits cbd0cefb9cc87744286fde23632860354f5c62ee (actually merged in the release) and abcb73f08f20111ff3519adde44f5714cc61acaf (was in my PR, but cherry-picked into #1804).