search

microsoft / VS-ColorThemes

Visual Studio Extension that installs additional color themes
https://marketplace.visualstudio.com/items?itemName=JustinClareburtMSFT.ColorThemesforVisualStudio
MIT License
334 stars 89 forks source link

Solarized Dark cshtml colors look wrong #6

Open styfle opened 6 years ago

styfle commented 6 years ago

I found a problem with Solarized Dark theme in cshtml files. The C# code is highlighed in gray.

img

styfle commented 6 years ago

Also CSS looks like the only style applied is background color. The foreground colors are wrong:

image

prnadago commented 6 years ago

Hey @styfle do you think you can take a stab at fixing this by editing the color theme and submitting a PR?

styfle commented 6 years ago

I can probably fix the cshtml because it's one color. But the .css would take a lot of time since it looks like no colors or assigned besides background.

Are there docs on contributing? I don't know how to generate the files from my theme.

prnadago commented 6 years ago

To generate the file of a custom theme, go to Tools -> Customize Colors. In the lower 'Custom Themes' section, hover over the theme you want to export and click on Edit Theme. In this pane, there's an Export Theme icon at the top, which allows you to save the theme file. It needs to be saved as an xml filetype in order to be added to the Color Themes extension.

ghenriks commented 6 years ago

The colours in Visual Studio are unreadable - I get black text which just disappears given the fairly dark background colour.

If it helps though Visual Studio Code appears to get the colours right - the background is a bit lighter in colour, and there is no black text used.

MikhailKrasnobaev commented 6 years ago

Good day. I have xtracted the old (vs2015) solarized dark. Mod Solarized Dark.zip

You can import it to vs2017. Looks the same. 2018-01-12_16-02-47

styfle commented 6 years ago

@MikhailKrasnobaev The .cs file looks good. How does the .cshtml file look?

cheeseweasel commented 5 years ago

@styfle, I'm not sure exactly how this project is setting the colours for the editor, but I have both this and the https://github.com/leddt/visualstudio-colors-solarized visual studio settings projects running at the same time, and I've had the same issue with .cshtml files.

I found an issue with the other repo, and a typo of the RazorCode setting. There is a fork here: https://github.com/cheeseweasel/visualstudio-colors-solarized with fixes for both 2017 themes if that's a help. Should resolve your css file problems too.

alentor commented 4 years ago

Can confirm, solarized is nothing like it should be, take a look at vscode how it should look like..

maxbolen commented 4 years ago

Thanks for this, solarized has been my goto and it was basically unusable in C++ (namespaces are black on dark bg for one example). Thanks!