search

microsoft / VS-PPT

Productivity Power Tools - a set of Visual Studio extensions improving developer productivity.
http://aka.ms/extendvs
Other
885 stars 146 forks source link

Unit test coverage is not adequate #1

Open olegtk opened 8 years ago

olegtk commented 8 years ago

Desperately need moar unit tests.

LegalizeAdulthood commented 8 years ago

Maybe require unit tests for new contributions? Then things only get better from here.

mjring commented 8 years ago

Any guidelines or direction on which unit test framework to leverage for this? MSTest vs. NUnit vs. xUnit? Do we want to be consistent across features?

olegtk commented 8 years ago

There are some unit tests in the repo already (using mstest), but overall there are no requirements. AppVeyor also supports all these 3 frameworks. I think keeping using mstest would be less work, but not sure.

LegalizeAdulthood commented 8 years ago

Everyone I know uses NUnit, but I haven't done any C# stuff for some time now, maybe MSTest doesn't suck so bad anymore? I would accept new tests in either framework :smile_cat: but it is perhaps better to suggest a particular one for people who have no existing knowledge or preference. If existing tests are MSTest, then perhaps it is better to stick with the existing framework instead of introducing a new one. YMMV

mjring commented 8 years ago

I actually was thinking either NUnit or xUnit.net as preferred unit test frameworks, since they are more flexible than MSTest. Also looked at other Microsoft OSS projects and it looks like xUnit.net or NUnit are being utilized (moreso xUnit.net).

Any objections to leveraging xUnit as a standard unit test framework for this?

Ky7m commented 8 years ago

From my point of view xUnit is more preferable. I'm not sure that VS-PPT should be cross-platform (xUnit is cross-platform framework and this is killer feature), but I see that xUnit is more popular and even we can use official tool (https://github.com/dotnet/codeformatter) to convert MSTest tests to xUnit

olegtk commented 8 years ago

I agree xUnit is preferable. Let's go for with xUnit then.

eriawan commented 7 years ago

@olegtk any updates on the migration to xUnit?

I couldn't see/find any PR related to migrating to xUnit. If there hasn't migrated yet, I'd like to create new issue and related PR for this. After migrating, then we could revisit this unit test coverage, imho 🙂