search

microsoft / VS-PPT

Productivity Power Tools - a set of Visual Studio extensions improving developer productivity.
http://aka.ms/extendvs
Other
885 stars 146 forks source link

Provide an option to enable highlighting only of **selected word** for Match Margin 2017 #135

Open NoelAbrahams opened 7 years ago

NoelAbrahams commented 7 years ago

Hi, Guys,

Version: 15.0.5 VS 2017

The Match Margin is a very useful extension.

As it stands if I set the cursor on an item in the code editor it will highlight all occurrences.

This behaviour can be a bit intrusive. I only want the highlighting to occur when I select a word, i.e. by double-clicking on it.

This is how the competing extension (which I have been using for years) works.

Since this is a breaking change, it should be optional.

Thanks!

justcla commented 7 years ago

Thanks for your suggestion. I'm not sure what you mean about it being a breaking change. The behavior has not changed from version to version. Our implementation has always been this way.

Some people like the current behavior and might be unhappy if they had to make the extra effort to select a word to see the matches appear on the scroll bar.

If the other extension has the behavior you prefer, I recommend you use that one instead.

NoelAbrahams commented 7 years ago

hi, @justcla,

Some people like the current behavior and might be unhappy

That's what I mean by a breaking change. Keep the behaviour as it is but provide an option 'only highlight on whole word select' for people like me.

If the other extension has the behavior you prefer, I recommend you use that one instead.

There is a significant limitation with the other extension (which is called "Highlight all occurrences of selected word"). Basically, it only displays the glyph on the left margin - and not on the right margin as done by your "Match Margin" extension. This means it's not possible to see all occurrences in a document at once.

Furthermore, that extension is not being maintained and it's not possible to ask them to fix it.

Thanks.

justcla commented 7 years ago

I understand now. Yes, I suppose that would be a nice option to implement. The source code for Match Margin is available. Any chance you could submit a pull request?

NoelAbrahams commented 7 years ago

@justcla, I'm afraid that will not be possible at this time. We are a startup with very limited resources.

MStachowicz commented 3 years ago

I second this request, on large files/projects I instinctively click around the code and the UI can become unresponsive. Same goes when I finish typing a word and everything matching is highlighted. Making this optional would be A1