search

microsoft / VS-PPT

Productivity Power Tools - a set of Visual Studio extensions improving developer productivity.
http://aka.ms/extendvs
Other
885 stars 146 forks source link

Add cancellation to HtmlCopy GetAllClassificationSpans #243

Closed KirillOsenkov closed 3 years ago

KirillOsenkov commented 3 years ago

Fixes https://github.com/microsoft/VS-PPT/issues/242 Fixes https://github.com/microsoft/VS-PPT/issues/239

KirillOsenkov commented 3 years ago

Hmm I fear if clicking Cancel does nothing then cancellation token might not be checked too often: https://github.com/microsoft/VS-PPT/issues/242#issuecomment-791961049

Still I think it’s a good change to make but we need to keep thinking

KirillOsenkov commented 3 years ago

@cyrusnajmabadi @olegtk