VSSDK003 is created despite override GetAsyncToolWindowFactory being present

AdmiralSnyder commented 2 years ago

Bug description

the analyzer doesn't stop complaining even though the GetAsyncToolWindowFactory() method is there. see Screenshots here: https://github.com/AdmiralSnyder/ErrorRepros#20220216---the-analyzer-that-wants-me-to-asynchronously-create-tool-windows-doesnt-stop-whining

see repro here: https://github.com/AdmiralSnyder/ErrorRepros/tree/master/20220216_AsyncPackage_AsyncToolWindow/VsixProjectWithToolWindowCommunity

Version of the vssdk-analyzers: Since i just updated VS to 17.2 preview 1, and it crashes in NormalizePath, i cannot really tell you which SDK analyzer version i'm running ( guess the latest, though) - maybe the screenshot will help
Analyzer rule: Support async tool windows
Error (exception message, type, and callstack where applicable):

To Reproduce

Steps or code to reproduce the behavior:

create new project of type
Go to the ...Package.cs
add an override for the GetAsyncToolWindowFactory method
See error

Expected behavior

the analyzer should not complain anymore

Screenshots

AArnott commented 2 years ago

This does not repro for me when I create a vsix project with the project template that ships with VS and add a tool window to it.

It only repros with your project or repro steps of using a community-owned template because that brings in an older version of these analyzers. If you install the latest stable release of the analyzers into your project, the VSSDK003 diagnostic vanishes.

AdmiralSnyder commented 2 years ago

I can confirm, updating the Microsoft.VSSDK.BuildTools nuget package to 17.1.4054 solved it.

microsoft / VSSDK-Analyzers