search

microsoft / VSTS-Docker-Preview

Preview repo for Docker extension
16 stars 8 forks source link

Passwords are shown in clear text in build logs #5

Closed RemyBoyer closed 7 years ago

RemyBoyer commented 8 years ago

The passwords should be shown as ***.

Currently, it's shown when a Docker task, for any action.

The docker compose task if fine though. The passwords are correctly hidden.

Example when using a build action with DockerHub:

##[Debug] 2016-07-10T17:33:20.612Z: /usr/bin/docker arg: login
##[Debug] 2016-07-10T17:33:20.612Z: /usr/bin/docker arg: -e myemail@gmail.com
##[Debug] 2016-07-10T17:33:20.612Z: /usr/bin/docker arg: -u myusername
##[Debug] 2016-07-10T17:33:20.612Z: /usr/bin/docker arg: -p mypassword
##[Debug] 2016-07-10T17:33:20.613Z: /usr/bin/docker arg: https://index.docker.io/v1/
##[Debug] 2016-07-10T17:33:20.632Z: exec tool: /usr/bin/docker
##[Debug] 2016-07-10T17:33:20.632Z: Arguments:
##[Debug] 2016-07-10T17:33:20.632Z:    --tls
##[Debug] 2016-07-10T17:33:20.633Z:    --tlscacert='.dockercerts/ca.pem'
##[Debug] 2016-07-10T17:33:20.633Z:    --tlscert='.dockercerts/cert.pem'
##[Debug] 2016-07-10T17:33:20.633Z:    --tlskey='.dockercerts/key.pem'
##[Debug] 2016-07-10T17:33:20.633Z:    -H
##[Debug] 2016-07-10T17:33:20.633Z:    tcp://1.2.3.4:2376/
##[Debug] 2016-07-10T17:33:20.633Z:    login
##[Debug] 2016-07-10T17:33:20.641Z:    -e
##[Debug] 2016-07-10T17:33:20.641Z:    myemail@gmail.com
##[Debug] 2016-07-10T17:33:20.642Z:    -u
##[Debug] 2016-07-10T17:33:20.642Z:    myusername
##[Debug] 2016-07-10T17:33:20.652Z:    -p
##[Debug] 2016-07-10T17:33:20.652Z:    mypassword
##[Debug] 2016-07-10T17:33:20.653Z:    https://index.docker.io/v1/
2016-07-10T17:33:20.653Z: [command]/usr/bin/docker --tls --tlscacert='.dockercerts/ca.pem' --tlscert='.dockercerts/cert.pem' --tlskey='.dockercerts/key.pem' -H tcp://1.2.3.4:2376/ login -e myemail@gmail.com -u myusername -p MyPassword https://index.docker.io/v1/
KrishnaAdityaB commented 8 years ago

Which version of build agent are you using? Is it windows or linux agent? can you share the version of both docker and docker-compose tasks by looking at the agent's tasks folder?

RemyBoyer commented 8 years ago

Hello,

I'm using the vso linux agent.

Docker: 0.1.5 DockerCompose: 0.1.12

stepro commented 7 years ago

@RemyBoyer, this should no longer be an issue if you use an updated agent as well as the latest extension version. Can you verify? Thanks!

RemyBoyer commented 7 years ago

Yes, it's fixed now. Thank you.