search

microsoft / VSTSAgent.PowerShell

Tools for managing and automating your Azure DevOps Agents.
MIT License
29 stars 23 forks source link

Support installation of node10-based pipelines-agent in lieu of vsts-agent #42

Closed tristanbarcelon closed 10 months ago

tristanbarcelon commented 11 months ago

Current implementation of Find-VstsAgent filters github releases where assets are prefixed with vsts-agent. Would it be possible to support installation of pipelines-agent through an additional optional string parameter named $AgentType to Install-VstsAgent and Find-VstsAgent? It could have a ValidateSet attribute to limit values to 'vsts-agent' and 'pipelines-agent' but with a default value of 'vsts-agent` to preserve compatibility with DSC code and downstream users. Major difference between the two are outlined here

jwittner commented 11 months ago

Any reason not to expand the filter to search for both all the time? I'm assuming there's no version overlap between them or anything right?

jwittner commented 11 months ago

Nm, they do share versions. In that I case I like your solution for an optional 'AgentType'. Happy to review a PR with the updates too!

tristanbarcelon commented 11 months ago

Thanks. I'll give it a shot. :) It's been 3 yrs since I last submitted a PR to a public repo in github.

tristanbarcelon commented 11 months ago

@jwittner I just submitted a pull request #43.

tristanbarcelon commented 10 months ago

Hi @jwittner, do you need a PR to merge to master or are you performing that step? Either way, I'll be installing version 2.0.20-develop to kick the tires.

jwittner commented 10 months ago

Hi @jwittner, do you need a PR to merge to master or are you performing that step? Either way, I'll be installing version 2.0.20-develop to kick the tires.

We'll let this change sit in develop for a bit in case we need anything further, then we'll pull it into master after some validation time has passed. :)