search

microsoft / VerifiableCredentials-Verification-SDK-Typescript

An SDK to help Relying Parties manages their Decentralized Identities and Verifiable Credentials.
MIT License
53 stars 14 forks source link

Keys for commit/reveal should be EC secp256k1 keys #54

Closed jmandel closed 4 years ago

jmandel commented 4 years ago

When provisioning keys for a commit/reveal pair...

https://github.com/microsoft/VerifiableCredentials-Verification-SDK-Typescript/blob/851f9cfdb1de13190d1ac268f62b578cd30b1371/lib/ApiCrypto/LongFormDid.ts#L99

  1. I believe the sidetree implementation expects these to be secp256k1 public keys, which wouldn't be compatible with a private AES-GCM key

  2. It'll be important to return the associated private key (or maybe following the keyStore pattern, write these keys to a relevant store)

beejones commented 4 years ago

The longform will be reworked in future iterations. The sidetree longform spec is also changed and the latest spec is implemented (https://github.com/microsoft/VerifiableCredentials-Verification-SDK-Typescript/commit/5a9b2fb917cbde72ba8f75ed513f6723b330fa37).