search

microsoft / VideoX

VideoX: a collection of video cross-modal models
Other
967 stars 160 forks source link

[X-CLIP] SampleFrames possible wrong arguments? #110

Open pha123661 opened 1 year ago

pha123661 commented 1 year ago

Hi,

Thanks for the excellent work. However, in this line of the dataloader: https://github.com/microsoft/VideoX/blob/71ef17ad97a021e123ba41b78376e21ef4094f75/X-CLIP/datasets/build.py#L249

The arguments are clip_len=1, num_clips=config.DATA.NUM_FRAMES. Shouldn't it be clip_len=config.DATA.NUM_FRAMES, frame_interval=1, num_clips=1?

Or did I miss something?

I look forward to your response, thanks.