search

microsoft / Viva-Connections-Extensibility-Beta

38 stars 6 forks source link

Small updates to lab 3 instructions #17

Closed jansenbe closed 3 years ago

jansenbe commented 3 years ago

Following code snippets should be added to the lab 3 instructions to be complete:

HelloWorldAdaptiveCardExtension.ts import { DetailedView } from './quickView/DetailedQuickView'; private _cardIndex: number;

QuickView.ts The instructions show:

import { DETAILED_QUICK_VIEW_REGISTRY_ID } from '../HelloWorldAdaptiveCardExtension`;

Note the backtick versus the single quote.

Overall just some small changes, but might help folks who are completely new to SPFx and TypeScript

ms-nichoi commented 3 years ago

Thanks for the feedback! Updated.

tinsheep commented 2 years ago

I feel like the import { DetailedView } from './quickView/DetailedQuickView'; should be in Step 2 instead of step 4 because you need it before the reload the workbench to do the test in Step 3 no?