search

microsoft / Viva-Connections-Extensibility-Beta

38 stars 6 forks source link

Indication for removing old ACE WebPart from workbench in Lab 2 #19

Closed michaelmaillot closed 3 years ago

michaelmaillot commented 3 years ago

Versions

[ Windows 10 ] Operating System [ 12.13.0 ] Node version [ 4.0.2 ] Gulp version [ 1.13.0-beta.5 ] SPFx Generator version (npm list -g @microsoft/generator-sharepoint)

Expected or Desired Behavior

After applying updates from Lab 1 to Lab 2, when running gulp serve -l --no-browser as mentioned here, we should be able to display the ACE WebPart with updates. The Lab should indicate to remove the WebPart and add it again, if a new property is added to an existing ACE WebPart property pane.

Observed Behavior

After applying updates from Lab 1 to Lab 2, when running gulp serve -l --no-browser as mentioned here, if we still have the Lab 1 webpart displayed and running the local server, after refreshing the workbench we have an error pointing CardView.ts file:

public get data(): IPrimaryTextCardParameters {
    const { title, description } = this.state.items[this.state.currentIndex]; // Error here
    return {
      description,
      primaryText: title
    };
}

As long as we don't remove the ACE webpart to add it again, this error occurs because the new WebPart property pane listId doesn't exist.

Steps to Reproduce

Follow the instructions from Lab 1 to Lab 2.

johnguy0 commented 3 years ago

Updated documentation