microsoft / Viva-Connections-Extensibility-Beta

38 stars 6 forks source link

[QuickView]: [Videos Not playing] #21

Closed TJ-Klug closed 2 years ago

TJ-Klug commented 3 years ago

Versions

[ Big Sur ] Operating System [ 12.13.0 ] Node version [ CLI version: 2.3.0 ] [ Local version: 4.0.2 ] Gulp version [ @microsoft/generator-sharepoint@1.13.0-beta.5 ] SPFx Generator version

Expected or Desired Behavior

Videos to play in Quick View

Observed Behavior

Video closes with an unhandled promise rejection after load.

https://user-images.githubusercontent.com/83296371/122974342-cffcd180-d357-11eb-91f6-149d3bcb59b2.mov

image

Steps to Reproduce

Add an mp4 to a quick view.

ms-nichoi commented 3 years ago

Thanks for reporting this.

This seems to be happening because the video starting to play is triggering the callout's dismiss handler.

dennisjsyi commented 2 years ago

Fixed callout dismissing on video play event.