search

microsoft / Viva-Connections-Extensibility-Beta

38 stars 6 forks source link

Lab 3 - Missing Import #7

Closed coreyroth closed 3 years ago

coreyroth commented 3 years ago

In Lab3, I found a few missing imports. It's simple enough to figure out but for a new user, these might prove to be barriers in completing the lab successfully.

The QuickView requires you to import IListItem but it's not included in the lab.

I resolved the issue by adding the following import to import IListItem.

import { IHelloWorldAdaptiveCardExtensionProps, IHelloWorldAdaptiveCardExtensionState, IListItem } from '../HelloWorldAdaptiveCardExtension';

Missing DetailedView import in HelloWorldAdaptiveCardExtensiont.ts. I would also consider renaming this view to DetailedQuickView so the filename and class name match.

Missing import IActionArguments in DetailedQuickView.ts.

Missing import DETAILED_QUICK_VIEW_REGISTRY_ID in QuickView.ts.

Missing import RenderType in HelloWorldAdaptiveCardExtensiont.ts.

johnguy0 commented 3 years ago

Thanks! I've updated the documentation.