search

microsoft / VoTT

Visual Object Tagging Tool: An electron app for building end to end Object Detection Models from Images and Videos.
MIT License
4.29k stars 837 forks source link

photo adjustment processing integration #242

Open abfleishman opened 6 years ago

abfleishman commented 6 years ago

Sometimes we are processing photos that were over-/under- exposed. It would be nice to be able to adjust contrast, brightness, colors, (basic photo editing adjustments) while viewing files. This would be nice to have a way to lock the change when switching images

kichinsky commented 6 years ago

We have an idea of visual canvas-based filters that might be applied to images, the basic infrastructure for that is implemented, but nothing exposed to the interface layer yet.

kichinsky commented 5 years ago

@abfleishman I added basic invertion filter as an example in the dev branch. Could you test it to check whether is it something you are looking for? I will add other visual filters then. #266

abfleishman commented 5 years ago

@kichinsky I am not yet up and running on the dev branch (something I hope to do this week)

abfleishman commented 5 years ago

@kichinsky I have the dev version running now and I think that the filter idea is what I am getting at, but to make it more useful I think it would need to have some keyboard integration. For instance, the "-" and "+" keys to adjust brightness, the "[" and "]" keys to adjust contrast, or "shift" and "-/+" to adjust saturation. Having a quick button (keyboard shortcut) to "reset" the image would be important too!
I think being able to quickly make adjustments is crucial.
For instances, I am looking through 100 images and I come to a very dark one. I want to just hit the "+" button a few times to lighten it up to check to make sure there are no objects of interest in there before moving to the next image. I could also see having 10 photos in a row that are all dark and would want a way to persist the filter from one image to the next until I have passed through the dark images and then I could hit reset and go back to normal.

abfleishman commented 5 years ago

@kichinsky I just saw that the "reset filters" dropdown menu option does not work. But the filter resets if you move to the next image and come back.

kichinsky commented 5 years ago

Fixed "reset filters" issue in #274.

kichinsky commented 5 years ago

Adjustments on brightness, contrast, etc. should be quite easy to implement from filter perspective.

I need to figure out the best options from the UI perspective: 1) avoid overcomplicated short-cuts or mixing with other features (e.g. using +/- for potential zooming in/out); 2) filters order is important in some cases (internally we have a pipeline of filters applied, but it is not exposed on the UI level yet); 3) expose settings on the GUI level (not just short-cuts).

kichinsky commented 5 years ago

Hey, some updates here:

  1. I'm going to add soon few basic filters (saturation, brightness, contrast).
  2. As of now they will be exposed to the interface with predefined params (like allow only "increase brightness by 25%"). So it is not customizable, but I hope it still adds some value.

  3. FIlters are not combined into a pipeline. So adding a new filter, clears the previos one.

  4. I think a more advanced UI for managing filters will be ready in parallel with a VoTT v.2 release.