search

microsoft / VoTT

Visual Object Tagging Tool: An electron app for building end to end Object Detection Models from Images and Videos.
MIT License
4.3k stars 837 forks source link

fix: Revert horizontal asset bar #881

Closed wbreza closed 5 years ago

wbreza commented 5 years ago

The horizontal asset bar looks more visually appealing on the bottom and it also opens up more real estate for the main editing surface.

However, it also reduces the overall usability of the app. The vertical scrolling behavior on the moues wheel no longer works and the keyboard shortcut hot keys are inverted.

Let's revert this change for now until we are able to overcome these critical usability requirements.

codecov[bot] commented 5 years ago

Codecov Report

Merging #881 into develop will decrease coverage by 0.35%. The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #881      +/-   ##
===========================================
- Coverage    88.15%   87.79%   -0.36%     
===========================================
  Files          130      130              
  Lines         4878     4876       -2     
  Branches       903      903              
===========================================
- Hits          4300     4281      -19     
- Misses         576      593      +17     
  Partials         2        2
Impacted Files Coverage Δ
...c/react/components/pages/editorPage/editorPage.tsx 83.33% <100%> (ø) :arrow_up:
...eact/components/pages/editorPage/editorSideBar.tsx 39.58% <37.5%> (-36.42%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4f9f65...68e9edd. Read the comment docs.