search

microsoft / VoTT

Visual Object Tagging Tool: An electron app for building end to end Object Detection Models from Images and Videos.
MIT License
4.3k stars 837 forks source link

johnshew/login #882

Closed johnshew closed 5 years ago

johnshew commented 5 years ago

Adds a nodejs server integrated Microsoft graph to store VoTT profile information

johnshew commented 5 years ago

Starting the PR process. Any suggestions or recommendations appreciated.

codecov[bot] commented 5 years ago

Codecov Report

Merging #882 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #882   +/-   ##
======================================
  Coverage    87.9%   87.9%           
======================================
  Files         129     129           
  Lines        4845    4845           
  Branches      922     897   -25     
======================================
  Hits         4259    4259           
  Misses        584     584           
  Partials        2       2
Impacted Files Coverage Δ
src/common/htmlFileReader.ts 89.53% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 745e854...6484f43. Read the comment docs.

wbreza commented 5 years ago

@johnshew I changed the base of the PR to target the develop branch.

MichaelCVelez commented 5 years ago

Hello @johnshew

I am anxious to try out the login server you have created since this is a functionality I’ve been hoping for in VoTT for quite some time now. Do you have any guidance for running it? I have compiled the development branch and tried executing the server using npm start, but noticed the lib folder is missing since it’s ignored by git.

Do you have steps for how I can run the login feature?

Thank you in advance