Codecov Report

Merging #922 into develop will decrease coverage by 0.09%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           develop    #922     +/-   ##
=========================================
- Coverage     87.9%   87.8%   -0.1%     
=========================================
  Files          129     131      +2     
  Lines         4845    4963    +118     
  Branches       922     984     +62     
=========================================
+ Hits          4259    4358     +99     
- Misses         584     603     +19     
  Partials         2       2

Impacted Files	Coverage Δ
src/common/strings.ts	`100% <ø> (ø)`	:arrow_up:
src/common/localization/ja.ts	`100% <100%> (ø)`
src/providers/export/pascalVOC.ts	`79.44% <0%> (-4.77%)`	:arrow_down:
src/providers/export/cntk.ts	`96.96% <0%> (-0.65%)`	:arrow_down:
src/setupTests.js	`100% <0%> (ø)`	:arrow_up:
src/providers/export/testAssetsSplitHelper.ts	`100% <0%> (ø)`
...nents/common/connectionPicker/connectionPicker.tsx	`93.54% <0%> (+3.07%)`	:arrow_up:
src/common/ipcRendererProxy.ts	`66.66% <0%> (+4.76%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 745e854...09f284e. Read the comment docs.

peaceiris commented 4 years ago

Whitespace like the following should be removed.

- ローカル プロジェクトを開く
+ ローカルプロジェクトを開く

bart-jansen commented 4 years ago

Thanks a lot @peaceiris ! Really appreciate the feedback, got it verified by @aykhara and everything looks great and is added in https://github.com/microsoft/VoTT/pull/922/commits/bf0d273c6f9823d8928c64dce2fa1ab6c36dee9e

@PIC123 @wbreza can you guys merge this?

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

microsoft / VoTT

feat: Japanese language support #922

Codecov Report