microsoft / VoTT

Visual Object Tagging Tool: An electron app for building end to end Object Detection Models from Images and Videos.
MIT License
4.27k stars 833 forks source link

Browser Production version local file system support novel effort started to complete. #978

Open goodengineer opened 4 years ago

goodengineer commented 4 years ago

Dear Friends.

Hope all will improve with US.

1) I think it may be really not a drawback to add local file system project and asset stored on, remember "exclude desktop functionality from browser target", now to include it slightly modified.

I have started the code modifications, made a few changes, paused on next:

Screenshot (1673)

Can you advance by pointing up why the "Type Error: window.require is not a function?"

I searched the codes and found only appearances of !!window["require"] and no specific error dialog display invocations...

The objective is to make the Open Local Project working fully in Browser as in the Electron version within my version of the VoTT codes, please point up which files to consider and which changes to make?

Kind Regards, Paul. Screenshot (1669) Screenshot (1670)

series8217 commented 4 years ago

Hi Paul,

VoTT uses electron's IpcRenderer to implement the local file system backend. You will need to rewrite the file system provider to use something else.

Take a look at ipcRendererProxy.ts which is used by all the localFileSystemProxy methods.

IpcRendererProxy.ipcRenderer = (window as any).require("electron").ipcRenderer;

goodengineer commented 4 years ago

Hi Steven.

Tnx for your response and hint.

1) Will check ipcRendererProxy.ts later on...

Still, why this error: ""Type Error: window.require is not a function?"

2) What is meant in my idea is that the VoTT web browser version in previous commits was supporting opening projects from both cloud and local file systems, right? It is that is meant in my post, how to recover (which particular commit, code version) production build still supports both local file system and cloud(web-based) for web-based version(GUI)?

Best Regards, Paul.

series8217 commented 4 years ago

The VoTT web browser version has never supported local file systems. There is no commit that has local file system working for the web based version.

Before the v2.0 release, VoTT was electron-only.