search

microsoft / WebRTC-universal-samples

WebRTC samples for the Universal Windows Platform.
177 stars 71 forks source link

Cannot build PeerConnectionClient.sln after upgrading WebRtc package to 1.71.07 #66

Open stephenstarkie opened 5 years ago

stephenstarkie commented 5 years ago

I cloned the WebRTC-universal-samples and built \Samples\PeerCC-Sample PeerConnectionClient.WebRtc.sln - it compiled fine with WebRtc 1.62.1.1-Beta (as referenced when cloned). I tried to update the package to the latest (1.71.0.7) and there are many missing definitions in Conductor.cs. Using Object Browser shows that the changes between 1.62.1.1-Beta and 1.71.0.7 are VERY significant and I cannot find information about how to update the source to work - there doesn't seem to be a more recent sample.

jamescadd commented 5 years ago

Hello, the latest PeerCC sample code is available here - just change the reference to WebRtc.Org to use the NuGet package and it should work: https://github.com/webrtc-uwp/PeerCC

You can also find an in-progress rewrite of PeerCC which is meant to be simpler and easier to understand here. Note it's a work in progress so you may run into some issues: https://github.com/webrtc-uwp/PeerCC-XPlatform

I'll leave this open until this repo has been updated with the latest.

Alexees commented 5 years ago

@jamescadd what does "just change the reference to WebRtc.Org to use the NuGet package" mean?

jamescadd commented 5 years ago

@Alexees you should see a reference (which is broken) to Org.WebRtc in the PeerConnectionClient project. Remove that reference, then go to "manage NuGet packages" and search for WebRTC; add the first result. Hth.

Noemata commented 5 years ago

The latest samples still have references like this:

Include="..........\webrtc\windows\projects\msvc\Org.WebRtc.Universal\Org.WebRtc.vcxproj">

Can we please get a sample that uses a nuget package?

Noemata commented 5 years ago

It's helpful to know that you folks are eating the same dishes we need to consume ;-)